OU-1213: IncidentPage add error state

[tremes]

This is adding use of AccessDenied to the IncidentPage when user doesn't have sufficient permissions.

Previously it displayed only spinning spinner.

When this fix is applied, it looks like:

[openshift-ci-robot]

@tremes: This pull request references OU-1213 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

This is adding use of AccessDenied to the IncidentPage when user doesn't have sufficient permissions.

Previously it displayed only spinning spinner.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@tremes: This pull request references OU-1213 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

This is adding use of AccessDenied to the IncidentPage when user doesn't have sufficient permissions.

Previously it displayed only spinning spinner.

When this fix is applied, it looks like:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jgbernalp]

This makes the logic a bit hard to follow. Should we nest the ternary?

loadError ? <...> : (
  alertsAreLoading && incidentsAreLoading ? <... > : <...>
)

[jgbernalp]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgbernalp, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [jgbernalp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@tremes: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.