Skip to content

OCPBUGS-88546: Update Go directive and build_root_image to be consistent with ART for 4.12#296

Open
Atharva-Shinde wants to merge 1 commit into
openshift:release-4.12from
Atharva-Shinde:4.12-art-sync
Open

OCPBUGS-88546: Update Go directive and build_root_image to be consistent with ART for 4.12#296
Atharva-Shinde wants to merge 1 commit into
openshift:release-4.12from
Atharva-Shinde:4.12-art-sync

Conversation

@Atharva-Shinde

@Atharva-Shinde Atharva-Shinde commented May 11, 2026

Copy link
Copy Markdown

There is a skew between the Go versions used for building, testing and the Go directive inside the go.mod file. This PR is an effort to bring parity between ART and the component for the release-4.12 branch.

Changes:
build_root_image.tag: rhel-8-release-golang-1.19-openshift-4.12
Bump Go directive to 1.19

@coderabbitai

coderabbitai Bot commented May 11, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: becedd3e-9c09-41b6-b752-a15373d1e04d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot requested review from dougbtv and s1061123 May 11, 2026 05:27
@openshift-ci

openshift-ci Bot commented May 11, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Atharva-Shinde
Once this PR has been reviewed and has the lgtm label, please assign dougbtv for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Atharva-Shinde Atharva-Shinde changed the title Update build_root_image to be consistent with ART for 4.12 OCPBUGS-88546 Update go directive and build_root_image to be consistent with ART for 4.12 Jun 25, 2026
@Atharva-Shinde Atharva-Shinde changed the title OCPBUGS-88546 Update go directive and build_root_image to be consistent with ART for 4.12 OCPBUGS-88546: Update go directive and build_root_image to be consistent with ART for 4.12 Jun 25, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 25, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@Atharva-Shinde: This pull request references Jira Issue OCPBUGS-88546, which is invalid:

  • expected the bug to target the "4.12.z" version, but no target version was set
  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-88546 to depend on a bug targeting a version in 4.13.0, 4.13.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jun 25, 2026
@Atharva-Shinde Atharva-Shinde changed the title OCPBUGS-88546: Update go directive and build_root_image to be consistent with ART for 4.12 OCPBUGS-88546: Update Go directive and build_root_image to be consistent with ART for 4.12 Jun 25, 2026
@Atharva-Shinde Atharva-Shinde force-pushed the 4.12-art-sync branch 3 times, most recently from a7c33f4 to 2804a5a Compare June 25, 2026 05:51
…r 4.12

Signed-off-by: Atharva Shinde <atshinde@redhat.com>
@openshift-ci

openshift-ci Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

@Atharva-Shinde: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security f284cc9 link false /test security

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants