NO-JIRA: Remove sync with github ci-flake#181
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@maayanf24: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe PR removes GitHub issue synchronization processing from the ChangesGitHub Processing Removal and Severity Field Update
🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
openshift-ci
Bot
added
the
needs-ok-to-test
|
Hi @maayanf24. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
jira-scripts/README.md (1)
46-46:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winRemove stale
[-g]from usage docs to match current CLI.The usage line still advertises
[-g], butparse_input_args()no longer defines that flag. This leaves the README inconsistent with the script interface and the PR objective.Suggested doc fix
-usage: network_bugs_overview [-h] [--jira-bugs] [--jira-escalations] [-v] [-q] [-n] [-g] [--old-bugs] +usage: network_bugs_overview [-h] [--jira-bugs] [--jira-escalations] [-v] [-q] [-n] [--old-bugs]🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@jira-scripts/README.md` at line 46, The README usage line still includes the obsolete [-g] flag; remove the `[-g]` token from the usage string so it matches the current CLI defined by parse_input_args(). Locate the usage example line (the one starting with "usage: network_bugs_overview ...") and delete the `[-g]` entry, ensuring the documented flags align exactly with those created in parse_input_args().jira-scripts/network_bugs_overview (1)
873-945:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winAlign the documented/default CLI behavior with what the parser now does.
default_strsays only Jira bugs are fetched by default, but the default branch also setsnew_bugs = True, and the providedjira-scripts/README.md:41-46snippet still advertises[-g]even though this parser no longer defines it. Please sync the help text and README with the actual defaults/options so users do not get surprised by extra output or unrecognized flags.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@jira-scripts/network_bugs_overview` around lines 873 - 945, Update the CLI help text and README to reflect the actual defaults and available flags: change default_str and the help strings for the "--jira-bugs", "--jira-escalations", and "--new-bugs" parser.add_argument calls so they state that both jira bugs and new-bugs are returned by default (or clearly state the behavior when no flags are passed), remove or update any README references to the obsolete "[-g]" flag, and ensure the parser logic (the args -> jira_bugs, jira_escalations, new_bugs assignment block around args and the default branch) and docs are consistent about which flags enable which queries so users aren't misled by help text or README.
🧹 Nitpick comments (1)
jira-scripts/network_bugs_overview (1)
117-117: ⚡ Quick winMake the migrated severity field id a real constant.
The field id now lives in two string literals plus a commented-out constant, which makes the next Jira field migration easy to miss. Define
SEVERITY_JIRA_FIELDonce and reuse it in both call sites.♻️ Proposed cleanup
-# SEVERITY_JIRA_FIELD = "customfield_10840" # in OCPBUGS +SEVERITY_JIRA_FIELD = "customfield_10840" # in OCPBUGS ... - severity = getattr(bug.fields, 'customfield_10840', None) + severity = getattr(bug.fields, SEVERITY_JIRA_FIELD, None) ... - severity = getattr(bug.fields, 'customfield_10840', None) + severity = getattr(bug.fields, SEVERITY_JIRA_FIELD, None)Also applies to: 982-982, 1041-1041
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@jira-scripts/network_bugs_overview` at line 117, Define a single constant SEVERITY_JIRA_FIELD and use it in both places where the severity field id is currently hardcoded as string literals (and remove or replace the commented-out duplicate); update the two call sites that reference the literal field id to reference SEVERITY_JIRA_FIELD instead so the migrated severity id is centralized and only declared once.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@jira-scripts/network_bugs_overview`:
- Around line 873-945: Update the CLI help text and README to reflect the actual
defaults and available flags: change default_str and the help strings for the
"--jira-bugs", "--jira-escalations", and "--new-bugs" parser.add_argument calls
so they state that both jira bugs and new-bugs are returned by default (or
clearly state the behavior when no flags are passed), remove or update any
README references to the obsolete "[-g]" flag, and ensure the parser logic (the
args -> jira_bugs, jira_escalations, new_bugs assignment block around args and
the default branch) and docs are consistent about which flags enable which
queries so users aren't misled by help text or README.
In `@jira-scripts/README.md`:
- Line 46: The README usage line still includes the obsolete [-g] flag; remove
the `[-g]` token from the usage string so it matches the current CLI defined by
parse_input_args(). Locate the usage example line (the one starting with "usage:
network_bugs_overview ...") and delete the `[-g]` entry, ensuring the documented
flags align exactly with those created in parse_input_args().
---
Nitpick comments:
In `@jira-scripts/network_bugs_overview`:
- Line 117: Define a single constant SEVERITY_JIRA_FIELD and use it in both
places where the severity field id is currently hardcoded as string literals
(and remove or replace the commented-out duplicate); update the two call sites
that reference the literal field id to reference SEVERITY_JIRA_FIELD instead so
the migrated severity id is centralized and only declared once.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 7bba49dd-3edc-4a36-b61e-672301f8ecc2
📒 Files selected for processing (2)
jira-scripts/README.mdjira-scripts/network_bugs_overview
Remove the option to sync with ci-flake from github Update custom-field id post jira migration Signed-off-by: Maayan Friedman <maafried@redhat.com>
|
/ok-to-test |
openshift-ci
Bot
added
ok-to-test
|
/retest-required |
1 similar comment
|
/retest-required |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: arghosh93, maayanf24 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
/verified by @maayanf24 |
|
@maayanf24: Jira verification commands are restricted to collaborators for this repo. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
looks like you can delete this whole struct as well, since the only place it's used seems to be what you are removing below anyhow.
Remove github_to_jira_users array from network-bugs script Signed-off-by: Maayan Friedman <maafried@redhat.com>
|
@maayanf24: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@maayanf24: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
4 participants
Summary by CodeRabbit
Documentation
Chores