OCPBUGS-61001: v2/clusterresources: add def namespace to UpdateService by r4f4 · Pull Request #1262 · openshift/oc-mirror

r4f4 · 2025-09-16T13:14:18Z

Description

According to our docs, the default/recommended namespace is "openshift-update-service" [1]. If users want to use a custom namespace, they can edit the generated updateService.yaml file.

[1] https://docs.redhat.com/en/documentation/openshift_container_platform/4.19/html-single/disconnected_environments/index#update-service-install-web-console_updating-disconnected-cluster-osus

Github / Jira issue: OCPBUGS-61001

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Code Improvements (Refactoring, Performance, CI upgrades, etc)
Internal repo assets (diagrams / docs on github repo)
This change requires a documentation update on openshift docs

How Has This Been Tested?

WIP

Expected Outcome

updateService.yaml file contains the "openshift-update-service" namespace.

openshift-ci-robot · 2025-09-16T13:14:25Z

@r4f4: This pull request references Jira Issue OCPBUGS-61001, which is invalid:

expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Description

According to our docs, the default/recommended namespace is "openshift-update-service" [1]. If users want to use a custom namespace, they can edit the generated updateService.yaml file.

[1] https://docs.redhat.com/en/documentation/openshift_container_platform/4.19/html-single/disconnected_environments/index#update-service-install-web-console_updating-disconnected-cluster-osus

Github / Jira issue: OCPBUGS-61001

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)

New feature (non-breaking change which adds functionality)

Breaking change (fix or feature that would cause existing functionality to not work as expected)

Code Improvements (Refactoring, Performance, CI upgrades, etc)

Internal repo assets (diagrams / docs on github repo)

This change requires a documentation update on openshift docs

How Has This Been Tested?

WIP

Expected Outcome

updateService.yaml file contains the "openshift-update-service" namespace.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

r4f4 · 2025-09-16T13:14:36Z

/hold
for testing

r4f4 · 2025-09-16T13:15:08Z

/jira refresh

openshift-ci-robot · 2025-09-16T13:15:16Z

@r4f4: This pull request references Jira Issue OCPBUGS-61001, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.21.0) matches configured target version for branch (4.21.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @nidangavali

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

aguidirh

I jut realized that my code review for this PR was pending for a long time, sorry about that.

aguidirh · 2025-09-17T15:39:54Z

 		err := cr.UpdateServiceGenerator(graphImage, releaseImage)
-		if err != nil {
-			t.Fatalf("should not fail")
-		}
+		assert.NoError(t, err)

 		_, err = os.Stat(filepath.Join(workingDir, clusterResourcesDir))
-		if err != nil {
-			t.Fatalf("output folder should exist")
-		}
+		assert.NoError(t, err, "output folder should exist")

 		resourceFiles, err := os.ReadDir(filepath.Join(workingDir, clusterResourcesDir))
-		if err != nil {
-			t.Fatalf("ls output folder should not fail")
-		}
-
-		if len(resourceFiles) != 1 {
-			t.Fatalf("output folder should contain 1 updateservice.yaml file")
-		}
+		assert.NoError(t, err, "ls output folder should not fail")

+		assert.Len(t, resourceFiles, 1, "output folder should contain 1 updateservice.yaml file")
 		assert.Equal(t, updateServiceFilename, resourceFiles[0].Name())


Thanks for simplifying the test code with the assert module.

aguidirh · 2025-12-15T09:49:37Z

@r4f4 once PR is rebased I will add the required labels.

According to our docs, the default/recommended namespace is "openshift-update-service" [1]. If users want to use a custom namespace, they can edit the generated updateService.yaml file. [1] https://docs.redhat.com/en/documentation/openshift_container_platform/4.19/html-single/disconnected_environments/index#update-service-install-web-console_updating-disconnected-cluster-osus

openshift-ci · 2025-12-15T18:21:44Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: r4f4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [r4f4]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2025-12-15T18:38:25Z

@r4f4: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-bot · 2026-03-16T09:00:28Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

aguidirh · 2026-03-25T09:20:35Z

/lifecycle frozen

openshift-ci · 2026-03-25T09:20:38Z

@aguidirh: The lifecycle/frozen label cannot be applied to Pull Requests.

Details

In response to this:

/lifecycle frozen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci · 2026-03-25T09:20:46Z

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

coderabbitai · 2026-03-25T09:21:17Z

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)

do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9490a632-d121-475b-a5df-f671e11aaef9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 16, 2025

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 16, 2025

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 16, 2025

openshift-ci Bot requested review from lmzuccarelli, nidangavali and sherine-k September 16, 2025 13:15

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 9, 2025

aguidirh reviewed Dec 15, 2025

View reviewed changes

r4f4 force-pushed the ocpbugs-61001-update-service-namespace branch from 9983ba0 to f4d093c Compare December 15, 2025 18:21

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 15, 2025

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2025

openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 25, 2026

Conversation

r4f4 commented Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

How Has This Been Tested?

Expected Outcome

Uh oh!

openshift-ci-robot commented Sep 16, 2025

Description

Type of change

How Has This Been Tested?

Expected Outcome

Uh oh!

r4f4 commented Sep 16, 2025

Uh oh!

r4f4 commented Sep 16, 2025

Uh oh!

openshift-ci-robot commented Sep 16, 2025

Uh oh!

aguidirh left a comment

Choose a reason for hiding this comment

Uh oh!

aguidirh Sep 17, 2025

Choose a reason for hiding this comment

Uh oh!

aguidirh commented Dec 15, 2025

Uh oh!

openshift-ci Bot commented Dec 15, 2025

Uh oh!

openshift-ci Bot commented Dec 15, 2025

Uh oh!

openshift-bot commented Mar 16, 2026

Uh oh!

aguidirh commented Mar 25, 2026

Uh oh!

openshift-ci Bot commented Mar 25, 2026

Uh oh!

openshift-ci Bot commented Mar 25, 2026

Uh oh!

coderabbitai Bot commented Mar 25, 2026

Review skipped

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

r4f4 commented Sep 16, 2025 •

edited

Loading