Skip to content

NO-ISSUE: Synchronize From Upstream Repositories#1299

Open
openshift-bot wants to merge 3 commits into
openshift:mainfrom
openshift-bot:synchronize-upstream
Open

NO-ISSUE: Synchronize From Upstream Repositories#1299
openshift-bot wants to merge 3 commits into
openshift:mainfrom
openshift-bot:synchronize-upstream

Conversation

@openshift-bot
Copy link
Copy Markdown
Contributor

@openshift-bot openshift-bot commented May 15, 2026

The staging/ and vendor/ directories have been synchronized from the upstream repositories, pulling in the following commits:

Date Commit Author Message
2026-05-14 19:31:53 operator-framework/operator-lifecycle-manager@4e18ba8 Todd Short Update google.golang.org/grpc to v1.81.1 (#3831)
2026-05-19 14:45:54 operator-framework/operator-lifecycle-manager@9fea077 dependabot[bot] 🌱 Bump github.com/onsi/gomega from 1.40.0 to 1.41.0 (#3833)
2026-05-19 20:52:40 operator-framework/operator-lifecycle-manager@d3e6fe0 dependabot[bot] 🌱 Bump github.com/onsi/ginkgo/v2 from 2.28.3 to 2.29.0 (#3834)

This pull request is expected to merge without any human intervention. If tests are failing here, changes must land upstream to fix any issues so that future downstreaming efforts succeed.

/assign @openshift/openshift-team-operator-runtime

Summary by CodeRabbit

  • Chores
    • Updated underlying dependencies to latest stable versions, including testing and communication libraries.

@openshift-bot openshift-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels May 15, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@openshift-bot: This pull request explicitly references no jira issue.

Details

In response to this:

The staging/ and vendor/ directories have been synchronized from the upstream repositories, pulling in the following commits:

Date Commit Author Message
2026-05-14 19:31:53 operator-framework/operator-lifecycle-manager@4e18ba8 Todd Short Update google.golang.org/grpc to v1.81.1 (#3831)

This pull request is expected to merge without any human intervention. If tests are failing here, changes must land upstream to fix any issues so that future downstreaming efforts succeed.

/assign @openshift/openshift-team-operator-runtime

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 15, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 15, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 879fdc66-a141-47b8-ac4c-dbbd7979e9b1

📥 Commits

Reviewing files that changed from the base of the PR and between d2d4ee8 and 7a13d11.

⛔ Files ignored due to path filters (8)
  • go.sum is excluded by !**/*.sum
  • staging/operator-lifecycle-manager/go.sum is excluded by !**/*.sum
  • vendor/github.com/onsi/ginkgo/v2/ginkgo/outline/ginkgo.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/onsi/ginkgo/v2/ginkgo/outline/outline.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/onsi/ginkgo/v2/types/version.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/onsi/gomega/types/types.go is excluded by !**/vendor/**, !vendor/**
  • vendor/google.golang.org/grpc/version.go is excluded by !**/vendor/**, !vendor/**
  • vendor/modules.txt is excluded by !**/vendor/**, !vendor/**
📒 Files selected for processing (2)
  • go.mod
  • staging/operator-lifecycle-manager/go.mod

Walkthrough

Bump test libraries and gRPC: github.com/onsi/ginkgo/v2 -> v2.29.0, github.com/onsi/gomega -> v1.41.0, and google.golang.org/grpc -> v1.81.1 in root go.mod and staging/operator-lifecycle-manager/go.mod.

Changes

Dependency version updates

Layer / File(s) Summary
Root module go.mod updates
go.mod
Updates indirect requirements: github.com/onsi/ginkgo/v2 to v2.29.0, github.com/onsi/gomega to v1.41.0, and google.golang.org/grpc to v1.81.1.
staging/operator-lifecycle-manager go.mod updates
staging/operator-lifecycle-manager/go.mod
Updates direct requirements: github.com/onsi/ginkgo/v2 and github.com/onsi/gomega to newer versions, and google.golang.org/grpc from v1.81.0 to v1.81.1.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels: lgtm

🚥 Pre-merge checks | ✅ 10 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Test Structure And Quality ⚠️ Warning Test "builds and manipulates bundle and index images" violates single responsibility (17 By() blocks), and 30 of 36 NotTo(HaveOccurred()) assertions lack meaningful failure messages. Break the multi-behavior test into separate focused tests; add descriptive messages to all assertions per the format: Expect(err).NotTo(HaveOccurred(), "context message").
Microshift Test Compatibility ⚠️ Warning New Ginkgo tests use configv1.ClusterOperator without MicroShift skip labels or apigroup tags. ClusterOperator API is unavailable on MicroShift. Add [apigroup:config.openshift.io] tag to Describe() or [Skipped:MicroShift] to It() tests, or use exutil.IsMicroShiftCluster() check with Skip().
✅ Passed checks (10 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'NO-ISSUE: Synchronize From Upstream Repositories' directly describes the main change: synchronizing staging/ and vendor/ directories from upstream repositories with updated dependency versions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Test names in added files use only hardcoded string values in fmt.Sprintf (e.g., "grpc-server", "unpack-bundles"), producing stable, deterministic test names across all runs.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No new Ginkgo e2e tests added; PR contains only dependency version updates in go.mod files. Custom check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR only updates Go module dependency versions in go.mod files. No deployment manifests, operator code, controllers, or scheduling constraints were introduced.
Ote Binary Stdout Contract ✅ Passed PR contains only go.mod dependency version updates (ginkgo v2.29.0, gomega v1.41.0, grpc v1.81.1) with no source code changes that could emit non-JSON stdout from process-level code.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR updates only dependency versions in go.mod and vendor files. No new Ginkgo e2e tests are added, so the IPv6/disconnected network compatibility check does not apply.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from bentito and camilamacedo86 May 15, 2026 00:04
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 15, 2026

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: openshift-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@perdasilva
Copy link
Copy Markdown
Contributor

/retest

1 similar comment
@tmshort
Copy link
Copy Markdown
Contributor

tmshort commented May 19, 2026

/retest

@openshift-bot openshift-bot force-pushed the synchronize-upstream branch from 0953a32 to d2d4ee8 Compare May 20, 2026 00:04
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label May 20, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 20, 2026

New changes are detected. LGTM label has been removed.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 20, 2026

@openshift-bot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

tmshort and others added 3 commits May 21, 2026 00:04
Signed-off-by: Todd Short <tshort@redhat.com>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: 4e18ba810803ef8605eda5ae8e32a10d1d4ce578
Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.40.0 to 1.41.0.
- [Release notes](https://github.com/onsi/gomega/releases)
- [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md)
- [Commits](onsi/gomega@v1.40.0...v1.41.0)

---
updated-dependencies:
- dependency-name: github.com/onsi/gomega
  dependency-version: 1.41.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: 9fea0774351aa3649189cfc4437260a20f748f0b
Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.28.3 to 2.29.0.
- [Release notes](https://github.com/onsi/ginkgo/releases)
- [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md)
- [Commits](onsi/ginkgo@v2.28.3...v2.29.0)

---
updated-dependencies:
- dependency-name: github.com/onsi/ginkgo/v2
  dependency-version: 2.29.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: d3e6fe0de91aad24e74825a87b8a9060a02e002c
@openshift-bot openshift-bot force-pushed the synchronize-upstream branch from d2d4ee8 to 7a13d11 Compare May 21, 2026 00:05
@openshift-bot openshift-bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2026
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label May 21, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 21, 2026

New changes are detected. LGTM label has been removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants