-
Notifications
You must be signed in to change notification settings - Fork 40
UPSTREAM: <carry>: add 85889 automation #603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bandrade The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| catalogImage := "quay.io/openshifttest/nginxolm-operator-index:nginxolm74924" | ||
| baseDir := exutil.FixturePath("testdata", "olm") | ||
| catalogTemplate := filepath.Join(baseDir, "clustercatalog-with-pollinterval.yaml") | ||
| outputDir := e2e.TestContext.OutputDir |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
outputDir := e2e.TestContext.OutputDir
if outputDir == "" {
outputDir = os.TempDir()
}
err := os.MkdirAll(outputDir, 0755)
o.Expect(err).NotTo(o.HaveOccurred())to
outputDir := "/tmp/" + caseID + "-"+exutil.GetRandomString()
err := os.MkdirAll(outputDir, 0755)
o.Expect(err).NotTo(o.HaveOccurred())
defer os.RemoveAll(outputDir)| o.Expect(err).NotTo(o.HaveOccurred()) | ||
| defer func() { | ||
| _ = pfCmd.Process.Kill() | ||
| _ = pfCmd.Wait() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bandrade do not need 'pfCmd.Wait()'
| o.Expect(svcPorts).To(o.ContainSubstring("443")) | ||
|
|
||
| g.By("Port-forward catalogd service") | ||
| pfCmd, _, _, err := oc.AsAdmin().WithoutNamespace().Run("port-forward").Args("-n", "openshift-catalogd", "svc/catalogd-catalogserver", "8443:443").Background() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bandrade suggest to use the way like GetContentURL to replace svc, and do not use port-forward.
Just FYI.
|
/payload-aggregate periodic-ci-openshift-operator-framework-operator-controller-release-4.22-periodics-e2e-gcp-ovn-fips-extended-f2 3 |
|
@kuiwang02: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/669f1200-f0f5-11f0-84d2-4d2ce215d1fe-0 |
| // test/qe/testdata/olm/cip.yaml | ||
| // test/qe/testdata/olm/clustercatalog-secret-withlabel.yaml | ||
| // test/qe/testdata/olm/clustercatalog-secret.yaml | ||
| // test/qe/testdata/olm/clustercatalog-with-pollinterval.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bandrade you miss to add the clustercatalog-with-pollinterval.yaml
|
@bandrade 85889 is failing. please refer to https://pr-payload-tests.ci.openshift.org/runs/ci/669f1200-f0f5-11f0-84d2-4d2ce215d1fe-0 |
No description provided.