Skip to content

Enable OTE for cluster-machine-approver#30884

Draft
sunzhaohua2 wants to merge 1 commit intoopenshift:mainfrom
sunzhaohua2:approver
Draft

Enable OTE for cluster-machine-approver#30884
sunzhaohua2 wants to merge 1 commit intoopenshift:mainfrom
sunzhaohua2:approver

Conversation

@sunzhaohua2
Copy link
Contributor

@sunzhaohua2 sunzhaohua2 commented Mar 16, 2026

@openshift-ci-robot
Copy link

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@coderabbitai
Copy link

coderabbitai bot commented Mar 16, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9ad5b006-18d0-4a81-b0bb-edcca55247af

📥 Commits

Reviewing files that changed from the base of the PR and between 1a298a1 and 619714b.

📒 Files selected for processing (1)
  • pkg/test/extensions/binary.go

Walkthrough

A new extension test binary entry for "cluster-machine-approver" is added to the extensionBinaries registry in the test utilities, mapping an imageTag to a binary path for external test distribution.

Changes

Cohort / File(s) Summary
Extension Test Binary Registry
pkg/test/extensions/binary.go
Added new entry to extensionBinaries registry: imageTag "cluster-machine-approver" with binaryPath "/usr/bin/cluster-machine-approver-ext.gz".

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.11.3)

Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions
The command is terminated due to an error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions


Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can disable the changed files summary in the walkthrough.

Disable the reviews.changed_files_summary setting to disable the changed files summary in the walkthrough.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 16, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sunzhaohua2
Once this PR has been reviewed and has the lgtm label, please assign neisw for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested review from deads2k and p0lyn0mial March 16, 2026 03:01
@sunzhaohua2
Copy link
Contributor Author

/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.22-e2e-aws-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 16, 2026

@sunzhaohua2: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

@sunzhaohua2
Copy link
Contributor Author

/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-ovn-serial-1of2

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 16, 2026

@sunzhaohua2: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-ovn-serial-1of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0771d1b0-20e7-11f1-9580-0f17640cd8e6-0

@sunzhaohua2
Copy link
Contributor Author

/payload-job periodic-ci-openshift-release-master-ci-4.22-e2e-aws-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 16, 2026

@sunzhaohua2: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

@sunzhaohua2
Copy link
Contributor Author

/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.22-e2e-aws-ovn openshift/cluster-machine-approver#294

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 16, 2026

@sunzhaohua2: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

@sunzhaohua2
Copy link
Contributor Author

/payload-job-with-prs periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-ovn-serial-1of2 openshift/cluster-machine-approver#294

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 16, 2026

@sunzhaohua2: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

@openshift-ci-robot
Copy link

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@sunzhaohua2
Copy link
Contributor Author

/payload periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-ovn-serial-1of2 openshift/cluster-machine-approver#294

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 16, 2026

@sunzhaohua2: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

@sunzhaohua2
Copy link
Contributor Author

/payload-job-with-prs periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-ovn-serial-1of2 openshift/cluster-machine-approver#294 #30884

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 16, 2026

@sunzhaohua2: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-ovn-serial-1of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/cf468f20-20ea-11f1-985c-856aadf54291-0

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 16, 2026

@sunzhaohua2: This PR was included in a payload test run from #30884
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-ovn-serial-1of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/cf468f20-20ea-11f1-985c-856aadf54291-0

@sunzhaohua2 sunzhaohua2 marked this pull request as draft March 16, 2026 03:51
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 16, 2026
@sunzhaohua2
Copy link
Contributor Author

From job log
we can see level=info msg="Listed 2 tests in 12.835287ms" binary=cluster-machine-approver-ext OTE found the tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants