Skip to content

NO-JIRA: Replace bug id 85677 with 90541#31350

Open
hongkailiu wants to merge 1 commit into
openshift:mainfrom
hongkailiu:OCPBUGS-85677-to-90541
Open

NO-JIRA: Replace bug id 85677 with 90541#31350
hongkailiu wants to merge 1 commit into
openshift:mainfrom
hongkailiu:OCPBUGS-85677-to-90541

Conversation

@hongkailiu

@hongkailiu hongkailiu commented Jun 29, 2026

Copy link
Copy Markdown
Member

85677 is closed as a dup of 90541

/cc @jluhrsen

Summary by CodeRabbit

  • Bug Fixes
    • Updated the handling of a known network-related operator progress condition to align with the latest tracked issue reference.
    • Kept existing behavior unchanged while refreshing the linked exception details.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci openshift-ci Bot requested a review from jluhrsen June 29, 2026 20:17
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 29, 2026
@openshift-ci

openshift-ci Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@hongkailiu hongkailiu changed the title replace bug id 85677 with 90541 NO-JIRA: Replace bug id 85677 with 90541 Jun 29, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 29, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@hongkailiu: This pull request explicitly references no jira issue.

Details

In response to this:

85677 is closed as a dup of 90541

/cc @jluhrsen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 4a45fe8a-f94c-4ae3-8212-168b9ffe27f6

📥 Commits

Reviewing files that changed from the base of the PR and between bcac961 and 5501c8c.

📒 Files selected for processing (2)
  • pkg/monitortests/clusterversionoperator/legacycvomonitortests/operators.go
  • test/extended/machines/scale.go

Walkthrough

Two files update the exception issue URL for the network clusteroperator's Progressing state from OCPBUGS-85677 to OCPBUGS-90541, one in the CVO monitor tests and one in the machines scale test.

Network Operator Exception URL Update

Layer / File(s) Summary
Update network operator exception URLs
pkg/monitortests/clusterversionoperator/legacycvomonitortests/operators.go, test/extended/machines/scale.go
The network operator exception link is changed from OCPBUGS-85677 to OCPBUGS-90541 in both the upgrade progressing-state check and the machines scale AfterEach helper.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (14 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: replacing bug ID 85677 with 90541.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed No unstable Ginkgo titles were introduced; the touched files keep static Describe/It strings, and the change is only an OCPBUGS URL update.
Test Structure And Quality ✅ Passed Only bug-reference URLs changed in existing helper mappings; no new test logic, timeouts, cleanup, or assertions were altered.
Microshift Test Compatibility ✅ Passed Only existing exception URLs changed; no new Ginkgo tests, APIs, or MicroShift-unsupported logic were added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only bug-reference URLs changed in existing exception maps; no new Ginkgo tests or multi-node assumptions were added.
Topology-Aware Scheduling Compatibility ✅ Passed Only issue URLs changed in test exception mappings; no manifests, controllers, or scheduling constraints were added or modified.
Ote Binary Stdout Contract ✅ Passed Diff only swaps OCPBUGS URLs in test helper/AfterEach blocks; no main/init/TestMain/BeforeSuite stdout writes were added.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The PR only changes OCPBUGS URL strings in existing test helpers; it adds no new Ginkgo tests, IPv4 assumptions, or external connectivity.
No-Weak-Crypto ✅ Passed The PR only changes bug-tracker URLs in exception maps; no weak crypto, custom crypto, or secret comparisons were added.
Container-Privileges ✅ Passed PR only changes bug URLs and removes one extension binary entry; no container/K8s manifest or privilege fields were added.
No-Sensitive-Data-In-Logs ✅ Passed PR only swaps OCPBUGS URLs in exception-return strings; no new or modified logging of sensitive data was introduced.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label Jun 29, 2026
@openshift-ci

openshift-ci Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hongkailiu
Once this PR has been reviewed and has the lgtm label, please assign jogeo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hongkailiu hongkailiu marked this pull request as ready for review June 29, 2026 20:52
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 29, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@openshift-ci

openshift-ci Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

@hongkailiu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-csi 5501c8c link true /test e2e-aws-csi
ci/prow/e2e-aws-ovn-microshift 5501c8c link true /test e2e-aws-ovn-microshift
ci/prow/e2e-gcp-ovn 5501c8c link true /test e2e-gcp-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants