Skip to content

[release-4.20] OCPBUGS-85523: Remove restriction of unmanaged x-k8s.io#31351

Open
rikatz wants to merge 2 commits into
openshift:release-4.20from
rikatz:cherry-pick-xk8sio-removal
Open

[release-4.20] OCPBUGS-85523: Remove restriction of unmanaged x-k8s.io#31351
rikatz wants to merge 2 commits into
openshift:release-4.20from
rikatz:cherry-pick-xk8sio-removal

Conversation

@rikatz

@rikatz rikatz commented Jun 29, 2026

Copy link
Copy Markdown
Member

Manual cherry-pick of #30718

This PR removes the restriction of users to install Gateway API CRDs from x-k8s.io group, given OSSM is able to ignore them.

The current PR removes the tests about this restriction before we are able to merge on cluster-ingress-operator

rikatz added 2 commits June 29, 2026 18:38
Previously, cluster-ingress-operator would manage and block any
    updates to CRDs that were from group gateway.networking.x-k8s.io.

    After some analysis we identified that OSSM/Istio does filter these
    resources in case it does not have a flag to enable alpha APIs, which means
    it is safe to allow users to deploy these CRDs.

    This way, this change removes any restriction on x-k8s.io group,
    and removes any further reconciliation from CIO on x-k8s.io group.

Signed-off-by: Ricardo Pchevuzinske Katz <katz@redhat.com>
@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jun 29, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@rikatz: This pull request references Jira Issue OCPBUGS-85523, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.z) matches configured target version for branch (4.20.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-74373 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-74373 targets the "4.21.z" version, which is one of the valid target versions: 4.21.0, 4.21.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (iamin@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Manual cherry-pick of #30718

This PR removes the restriction of users to install Gateway API CRDs from x-k8s.io group, given OSSM is able to ignore them.

The current PR removes the tests about this restriction before we are able to merge on cluster-ingress-operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: a8fcf7e9-2d14-4102-9f5f-f1c66fb52ea2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rikatz
Once this PR has been reviewed and has the lgtm label, please assign neisw for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

@rikatz: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants