RHDH: add RHDH catalog index and chart version Gangway overrides#79538
Merged
openshift-merge-bot[bot] merged 3 commits intoJun 1, 2026
Merged
Conversation
Contributor
|
Skipping CI for Draft Pull Request. |
openshift-ci
Bot
added
do-not-merge/work-in-progress
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughAdd empty-default ChangesCatalog Index and Chart Version Override Support
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
ci-operator/step-registry/redhat-developer/rhdh/send/data-router/redhat-developer-rhdh-send-data-router-commands.sh (1)
1-56:⚠️ Potential issue | 🔴 CriticalUse
set -euo pipefailinstead of disabling error handling.This step registry script must use
set -euo pipefail(without-x) as the default shell options, per the step registry guidelines. Lines 2-3 currently disable error and unset variable handling withset +o errexitandset +o nounset, which contradicts the requirement:#!/bin/bash set -euo pipefail🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/step-registry/redhat-developer/rhdh/send/data-router/redhat-developer-rhdh-send-data-router-commands.sh` around lines 1 - 56, Replace the current disabled error/unset handling (the two lines "set +o errexit" and "set +o nounset") with a single strict-mode line "set -euo pipefail" at the top of the script; then audit any uses of potentially unset variables (e.g. elements in OVERRIDE_VARS, JOB_SPEC parsing, SHARED_DIR reads, DATA_ROUTER_* secret reads, and functions like save_status_data_router_failed and get_artifacts_url) and make them robust by providing safe defaults or explicit checks (use parameter expansion like ${VAR:-} or conditional guards) so the script still behaves correctly under strict mode.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In
`@ci-operator/step-registry/redhat-developer/rhdh/send/data-router/redhat-developer-rhdh-send-data-router-commands.sh`:
- Around line 1-56: Replace the current disabled error/unset handling (the two
lines "set +o errexit" and "set +o nounset") with a single strict-mode line "set
-euo pipefail" at the top of the script; then audit any uses of potentially
unset variables (e.g. elements in OVERRIDE_VARS, JOB_SPEC parsing, SHARED_DIR
reads, DATA_ROUTER_* secret reads, and functions like
save_status_data_router_failed and get_artifacts_url) and make them robust by
providing safe defaults or explicit checks (use parameter expansion like
${VAR:-} or conditional guards) so the script still behaves correctly under
strict mode.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 14817316-9e09-44ec-8cb9-b6f14e39e168
📒 Files selected for processing (20)
ci-operator/step-registry/redhat-developer/rhdh/aks/helm/nightly/redhat-developer-rhdh-aks-helm-nightly-commands.shci-operator/step-registry/redhat-developer/rhdh/aks/helm/nightly/redhat-developer-rhdh-aks-helm-nightly-ref.yamlci-operator/step-registry/redhat-developer/rhdh/aks/operator/nightly/redhat-developer-rhdh-aks-operator-nightly-ref.yamlci-operator/step-registry/redhat-developer/rhdh/eks/helm/nightly/redhat-developer-rhdh-eks-helm-nightly-commands.shci-operator/step-registry/redhat-developer/rhdh/eks/helm/nightly/redhat-developer-rhdh-eks-helm-nightly-ref.yamlci-operator/step-registry/redhat-developer/rhdh/eks/operator/nightly/redhat-developer-rhdh-eks-operator-nightly-ref.yamlci-operator/step-registry/redhat-developer/rhdh/gke/helm/nightly/redhat-developer-rhdh-gke-helm-nightly-commands.shci-operator/step-registry/redhat-developer/rhdh/gke/helm/nightly/redhat-developer-rhdh-gke-helm-nightly-ref.yamlci-operator/step-registry/redhat-developer/rhdh/gke/operator/nightly/redhat-developer-rhdh-gke-operator-nightly-ref.yamlci-operator/step-registry/redhat-developer/rhdh/ocp/helm/nightly/redhat-developer-rhdh-ocp-helm-nightly-commands.shci-operator/step-registry/redhat-developer/rhdh/ocp/helm/nightly/redhat-developer-rhdh-ocp-helm-nightly-ref.yamlci-operator/step-registry/redhat-developer/rhdh/ocp/helm/redhat-developer-rhdh-ocp-helm-commands.shci-operator/step-registry/redhat-developer/rhdh/ocp/helm/redhat-developer-rhdh-ocp-helm-ref.yamlci-operator/step-registry/redhat-developer/rhdh/ocp/helm/upgrade/nightly/redhat-developer-rhdh-ocp-helm-upgrade-nightly-commands.shci-operator/step-registry/redhat-developer/rhdh/ocp/helm/upgrade/nightly/redhat-developer-rhdh-ocp-helm-upgrade-nightly-ref.yamlci-operator/step-registry/redhat-developer/rhdh/ocp/operator/nightly/redhat-developer-rhdh-ocp-operator-nightly-ref.yamlci-operator/step-registry/redhat-developer/rhdh/osd-gcp/helm/nightly/redhat-developer-rhdh-osd-gcp-helm-nightly-commands.shci-operator/step-registry/redhat-developer/rhdh/osd-gcp/helm/nightly/redhat-developer-rhdh-osd-gcp-helm-nightly-ref.yamlci-operator/step-registry/redhat-developer/rhdh/send/data-router/redhat-developer-rhdh-send-data-router-commands.shci-operator/step-registry/redhat-developer/rhdh/send/data-router/redhat-developer-rhdh-send-data-router-ref.yaml
zdrapela
force-pushed
the
feature/rhdh-catalog-index-gangway-overrides
branch
from
992119e to
b8d10fc
Compare
Add MULTISTAGE_PARAM_OVERRIDE_CATALOG_INDEX_IMAGE and MULTISTAGE_PARAM_OVERRIDE_CHART_VERSION env vars to all RHDH nightly/presubmit step registry refs and their data-router post step. When set via Gangway API, these overrides let callers specify a custom catalog index image and chart version for on-demand CI runs. The data-router step skips ReportPortal reporting when any Gangway override is detected. Assisted-by: Claude Code
zdrapela
force-pushed
the
feature/rhdh-catalog-index-gangway-overrides
branch
from
b8d10fc to
6fabf85
Compare
Extend Gangway API overrides (CATALOG_INDEX_IMAGE, CHART_VERSION, PLAYWRIGHT_VERSION) to rhdh-plugin-export-overlays step-registry steps and their data-router reporting step. Assisted-by: Claude Code Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
zdrapela
force-pushed
the
feature/rhdh-catalog-index-gangway-overrides
branch
from
6fabf85 to
fcf3e0d
Compare
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
Contributor
Author
|
@CodeRabbit full-review |
Contributor
🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Get the list of changed files in the PR
gh pr view 79538 --repo openshift/release --json files --jq '.files[].path'Length of output: 3116 🏁 Script executed: #!/bin/bash
# Fetch key commands.sh files to review
cat ci-operator/step-registry/redhat-developer/rhdh/ocp/helm/nightly/redhat-developer-rhdh-ocp-helm-nightly-commands.shLength of output: 12016 🏁 Script executed: #!/bin/bash
# Fetch ref.yaml for ocp/helm/nightly
cat ci-operator/step-registry/redhat-developer/rhdh/ocp/helm/nightly/redhat-developer-rhdh-ocp-helm-nightly-ref.yamlLength of output: 2052 🏁 Script executed: #!/bin/bash
# Fetch send/data-router commands.sh
cat ci-operator/step-registry/redhat-developer/rhdh/send/data-router/redhat-developer-rhdh-send-data-router-commands.shLength of output: 13509 🏁 Script executed: #!/bin/bash
# Fetch send/data-router ref.yaml
cat ci-operator/step-registry/redhat-developer/rhdh/send/data-router/redhat-developer-rhdh-send-data-router-ref.yamlLength of output: 1937 🏁 Script executed: #!/bin/bash
# Fetch ocp/helm (non-nightly) commands.sh
cat ci-operator/step-registry/redhat-developer/rhdh/ocp/helm/redhat-developer-rhdh-ocp-helm-commands.shLength of output: 13411 🏁 Script executed: #!/bin/bash
# Fetch ocp/helm/upgrade/nightly commands.sh
cat ci-operator/step-registry/redhat-developer/rhdh/ocp/helm/upgrade/nightly/redhat-developer-rhdh-ocp-helm-upgrade-nightly-commands.shLength of output: 12037 🏁 Script executed: #!/bin/bash
# Fetch aks/helm/nightly commands.sh
cat ci-operator/step-registry/redhat-developer/rhdh/aks/helm/nightly/redhat-developer-rhdh-aks-helm-nightly-commands.shLength of output: 10605 🏁 Script executed: #!/bin/bash
# Fetch eks/helm/nightly commands.sh
cat ci-operator/step-registry/redhat-developer/rhdh/eks/helm/nightly/redhat-developer-rhdh-eks-helm-nightly-commands.shLength of output: 11075 🏁 Script executed: #!/bin/bash
# Fetch gke/helm/nightly commands.sh
cat ci-operator/step-registry/redhat-developer/rhdh/gke/helm/nightly/redhat-developer-rhdh-gke-helm-nightly-commands.shLength of output: 10571 🏁 Script executed: #!/bin/bash
# Fetch osd-gcp/helm/nightly commands.sh
cat ci-operator/step-registry/redhat-developer/rhdh/osd-gcp/helm/nightly/redhat-developer-rhdh-osd-gcp-helm-nightly-commands.shLength of output: 9141 🏁 Script executed: #!/bin/bash
# Fetch rhdh-plugin-export-overlays files
cat ci-operator/step-registry/redhat-developer/rhdh-plugin-export-overlays/ocp/helm/redhat-developer-rhdh-plugin-export-overlays-ocp-helm-commands.sh
echo "---SEPARATOR---"
cat ci-operator/step-registry/redhat-developer/rhdh-plugin-export-overlays/ocp/helm/redhat-developer-rhdh-plugin-export-overlays-ocp-helm-ref.yaml
echo "---SEPARATOR---"
cat ci-operator/step-registry/redhat-developer/rhdh-plugin-export-overlays/send/data-router/redhat-developer-rhdh-plugin-export-overlays-send-data-router-commands.sh
echo "---SEPARATOR---"
cat ci-operator/step-registry/redhat-developer/rhdh-plugin-export-overlays/send/data-router/redhat-developer-rhdh-plugin-export-overlays-send-data-router-ref.yamlLength of output: 29693 🏁 Script executed: #!/bin/bash
# Check operator nightly ref.yaml files
cat ci-operator/step-registry/redhat-developer/rhdh/aks/operator/nightly/redhat-developer-rhdh-aks-operator-nightly-ref.yaml
echo "---SEPARATOR---"
cat ci-operator/step-registry/redhat-developer/rhdh/eks/operator/nightly/redhat-developer-rhdh-eks-operator-nightly-ref.yaml
echo "---SEPARATOR---"
cat ci-operator/step-registry/redhat-developer/rhdh/gke/operator/nightly/redhat-developer-rhdh-gke-operator-nightly-ref.yaml
echo "---SEPARATOR---"
cat ci-operator/step-registry/redhat-developer/rhdh/ocp/operator/nightly/redhat-developer-rhdh-ocp-operator-nightly-ref.yamlLength of output: 8109 🏁 Script executed: #!/bin/bash
# Check if there are any operator commands.sh for nightly that are symlinks or separate files
ls -la ci-operator/step-registry/redhat-developer/rhdh/aks/operator/nightly/
ls -la ci-operator/step-registry/redhat-developer/rhdh/eks/operator/nightly/
ls -la ci-operator/step-registry/redhat-developer/rhdh/gke/operator/nightly/
ls -la ci-operator/step-registry/redhat-developer/rhdh/ocp/operator/nightly/Length of output: 2730 🏁 Script executed: #!/bin/bash
# Check the ocp/helm upgrade nightly ref.yaml
cat ci-operator/step-registry/redhat-developer/rhdh/ocp/helm/upgrade/nightly/redhat-developer-rhdh-ocp-helm-upgrade-nightly-ref.yaml
echo "---SEPARATOR---"
# Check ocp/helm ref.yaml
cat ci-operator/step-registry/redhat-developer/rhdh/ocp/helm/redhat-developer-rhdh-ocp-helm-ref.yamlLength of output: 4020 🏁 Script executed: #!/bin/bash
# Check if osd-gcp operator nightly dir exists
ls -la ci-operator/step-registry/redhat-developer/rhdh/osd-gcp/ 2>/dev/null || echo "No osd-gcp directory"
ls -la ci-operator/step-registry/redhat-developer/rhdh/osd-gcp/operator/nightly/ 2>/dev/null || echo "No osd-gcp/operator/nightly directory"
# Also get osd-gcp/helm/nightly ref.yaml to confirm it's complete
cat ci-operator/step-registry/redhat-developer/rhdh/osd-gcp/helm/nightly/redhat-developer-rhdh-osd-gcp-helm-nightly-ref.yamlLength of output: 2721
SummaryThe PR consistently adds Issues Found1. Stale PR Description / BodyThe PR description (and the stated PR objectives) says:
But the actual implementation uses a single combined 2. No Logging of Final
|
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (2)
ci-operator/step-registry/redhat-developer/rhdh/osd-gcp/helm/nightly/redhat-developer-rhdh-osd-gcp-helm-nightly-commands.sh (1)
50-57: ⚡ Quick winLog final resolved catalog/chart values before test execution.
These lines only log when overrides are present. Add a final unconditional log of resolved
CATALOG_INDEX_IMAGEandCHART_VERSIONbefore running tests to simplify triage across Gangway and non-Gangway runs.Proposed patch
@@ echo "========== Current branch ==========" echo "Current branch: $(git branch --show-current)" if [[ "${IMAGE_REGISTRY}" == "quay.io" ]]; then @@ else echo "Using image: ${IMAGE_REGISTRY}/${IMAGE_REPO}:${TAG_NAME}" fi + +echo "Resolved CATALOG_INDEX_IMAGE: ${CATALOG_INDEX_IMAGE:-<empty>}" +echo "Resolved CHART_VERSION: ${CHART_VERSION:-<empty>}" echo "========== Test Execution ==========" echo "Executing openshift-ci-tests.sh" bash ./.ci/pipelines/openshift-ci-tests.sh🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/step-registry/redhat-developer/rhdh/osd-gcp/helm/nightly/redhat-developer-rhdh-osd-gcp-helm-nightly-commands.sh` around lines 50 - 57, The script only echoes CATALOG_INDEX_IMAGE and CHART_VERSION when override env vars are set, so add an unconditional log of the final resolved values to aid debugging: after the override blocks that set CATALOG_INDEX_IMAGE and CHART_VERSION (the blocks that check MULTISTAGE_PARAM_OVERRIDE_CATALOG_INDEX_IMAGE and MULTISTAGE_PARAM_OVERRIDE_CHART_VERSION) insert a simple echo that prints the final CATALOG_INDEX_IMAGE and CHART_VERSION values (e.g., "Resolved: CATALOG_INDEX_IMAGE=... CHART_VERSION=...") immediately before the test execution step so both Gangway and non-Gangway runs always emit the resolved values.ci-operator/step-registry/redhat-developer/rhdh/ocp/helm/nightly/redhat-developer-rhdh-ocp-helm-nightly-commands.sh (1)
50-57: ⚡ Quick winLog resolved catalog/chart values once after override handling.
Right now these values are only logged when an override is set. Add a single unconditional log after the override block so runs without Gangway overrides still show the effective
CATALOG_INDEX_IMAGEandCHART_VERSION.Suggested patch
if [[ -n "${MULTISTAGE_PARAM_OVERRIDE_CHART_VERSION}" ]]; then CHART_VERSION="${MULTISTAGE_PARAM_OVERRIDE_CHART_VERSION}" echo "Override applied: CHART_VERSION=${CHART_VERSION}" fi +echo "Resolved CATALOG_INDEX_IMAGE=${CATALOG_INDEX_IMAGE:-<empty>}" +echo "Resolved CHART_VERSION=${CHART_VERSION:-<empty>}"🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/step-registry/redhat-developer/rhdh/ocp/helm/nightly/redhat-developer-rhdh-ocp-helm-nightly-commands.sh` around lines 50 - 57, After the override block, add a single unconditional echo that logs the effective CATALOG_INDEX_IMAGE and CHART_VERSION so runs without overrides still report the resolved values; keep the existing override checks for MULTISTAGE_PARAM_OVERRIDE_CATALOG_INDEX_IMAGE and MULTISTAGE_PARAM_OVERRIDE_CHART_VERSION intact, then append an unconditional log like: echo "Resolved: CATALOG_INDEX_IMAGE=${CATALOG_INDEX_IMAGE} CHART_VERSION=${CHART_VERSION}" to surface the final values.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In
`@ci-operator/step-registry/redhat-developer/rhdh/ocp/helm/nightly/redhat-developer-rhdh-ocp-helm-nightly-commands.sh`:
- Around line 50-57: After the override block, add a single unconditional echo
that logs the effective CATALOG_INDEX_IMAGE and CHART_VERSION so runs without
overrides still report the resolved values; keep the existing override checks
for MULTISTAGE_PARAM_OVERRIDE_CATALOG_INDEX_IMAGE and
MULTISTAGE_PARAM_OVERRIDE_CHART_VERSION intact, then append an unconditional log
like: echo "Resolved: CATALOG_INDEX_IMAGE=${CATALOG_INDEX_IMAGE}
CHART_VERSION=${CHART_VERSION}" to surface the final values.
In
`@ci-operator/step-registry/redhat-developer/rhdh/osd-gcp/helm/nightly/redhat-developer-rhdh-osd-gcp-helm-nightly-commands.sh`:
- Around line 50-57: The script only echoes CATALOG_INDEX_IMAGE and
CHART_VERSION when override env vars are set, so add an unconditional log of the
final resolved values to aid debugging: after the override blocks that set
CATALOG_INDEX_IMAGE and CHART_VERSION (the blocks that check
MULTISTAGE_PARAM_OVERRIDE_CATALOG_INDEX_IMAGE and
MULTISTAGE_PARAM_OVERRIDE_CHART_VERSION) insert a simple echo that prints the
final CATALOG_INDEX_IMAGE and CHART_VERSION values (e.g., "Resolved:
CATALOG_INDEX_IMAGE=... CHART_VERSION=...") immediately before the test
execution step so both Gangway and non-Gangway runs always emit the resolved
values.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 1784bbc9-d99e-426a-b1d2-8cd9fcc3e3f8
📒 Files selected for processing (24)
ci-operator/step-registry/redhat-developer/rhdh-plugin-export-overlays/ocp/helm/redhat-developer-rhdh-plugin-export-overlays-ocp-helm-commands.shci-operator/step-registry/redhat-developer/rhdh-plugin-export-overlays/ocp/helm/redhat-developer-rhdh-plugin-export-overlays-ocp-helm-ref.yamlci-operator/step-registry/redhat-developer/rhdh-plugin-export-overlays/send/data-router/redhat-developer-rhdh-plugin-export-overlays-send-data-router-commands.shci-operator/step-registry/redhat-developer/rhdh-plugin-export-overlays/send/data-router/redhat-developer-rhdh-plugin-export-overlays-send-data-router-ref.yamlci-operator/step-registry/redhat-developer/rhdh/aks/helm/nightly/redhat-developer-rhdh-aks-helm-nightly-commands.shci-operator/step-registry/redhat-developer/rhdh/aks/helm/nightly/redhat-developer-rhdh-aks-helm-nightly-ref.yamlci-operator/step-registry/redhat-developer/rhdh/aks/operator/nightly/redhat-developer-rhdh-aks-operator-nightly-ref.yamlci-operator/step-registry/redhat-developer/rhdh/eks/helm/nightly/redhat-developer-rhdh-eks-helm-nightly-commands.shci-operator/step-registry/redhat-developer/rhdh/eks/helm/nightly/redhat-developer-rhdh-eks-helm-nightly-ref.yamlci-operator/step-registry/redhat-developer/rhdh/eks/operator/nightly/redhat-developer-rhdh-eks-operator-nightly-ref.yamlci-operator/step-registry/redhat-developer/rhdh/gke/helm/nightly/redhat-developer-rhdh-gke-helm-nightly-commands.shci-operator/step-registry/redhat-developer/rhdh/gke/helm/nightly/redhat-developer-rhdh-gke-helm-nightly-ref.yamlci-operator/step-registry/redhat-developer/rhdh/gke/operator/nightly/redhat-developer-rhdh-gke-operator-nightly-ref.yamlci-operator/step-registry/redhat-developer/rhdh/ocp/helm/nightly/redhat-developer-rhdh-ocp-helm-nightly-commands.shci-operator/step-registry/redhat-developer/rhdh/ocp/helm/nightly/redhat-developer-rhdh-ocp-helm-nightly-ref.yamlci-operator/step-registry/redhat-developer/rhdh/ocp/helm/redhat-developer-rhdh-ocp-helm-commands.shci-operator/step-registry/redhat-developer/rhdh/ocp/helm/redhat-developer-rhdh-ocp-helm-ref.yamlci-operator/step-registry/redhat-developer/rhdh/ocp/helm/upgrade/nightly/redhat-developer-rhdh-ocp-helm-upgrade-nightly-commands.shci-operator/step-registry/redhat-developer/rhdh/ocp/helm/upgrade/nightly/redhat-developer-rhdh-ocp-helm-upgrade-nightly-ref.yamlci-operator/step-registry/redhat-developer/rhdh/ocp/operator/nightly/redhat-developer-rhdh-ocp-operator-nightly-ref.yamlci-operator/step-registry/redhat-developer/rhdh/osd-gcp/helm/nightly/redhat-developer-rhdh-osd-gcp-helm-nightly-commands.shci-operator/step-registry/redhat-developer/rhdh/osd-gcp/helm/nightly/redhat-developer-rhdh-osd-gcp-helm-nightly-ref.yamlci-operator/step-registry/redhat-developer/rhdh/send/data-router/redhat-developer-rhdh-send-data-router-commands.shci-operator/step-registry/redhat-developer/rhdh/send/data-router/redhat-developer-rhdh-send-data-router-ref.yaml
Contributor
|
/approve |
…rade nightly Adds the export statement after image resolution in ocp-helm-upgrade-nightly-commands.sh to match the pattern in ocp-helm-commands.sh for consistency. Assisted-by: Claude Code Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
[REHEARSALNOTIFIER]
A total of 68 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
Contributor
Author
|
/pj-rehearse ack |
Contributor
|
@zdrapela: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
Contributor
|
@zdrapela: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: subhashkhileri, zdrapela The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
zdrapela
changed the title
krisnababu
pushed a commit
to oharan2/release
that referenced
this pull request
Jul 3, 2026
…hift#79538) * ci: add RHDH catalog index and chart version Gangway overrides Add MULTISTAGE_PARAM_OVERRIDE_CATALOG_INDEX_IMAGE and MULTISTAGE_PARAM_OVERRIDE_CHART_VERSION env vars to all RHDH nightly/presubmit step registry refs and their data-router post step. When set via Gangway API, these overrides let callers specify a custom catalog index image and chart version for on-demand CI runs. The data-router step skips ReportPortal reporting when any Gangway override is detected. Assisted-by: Claude Code * ci: add RHDH catalog index and chart version Gangway overrides Extend Gangway API overrides (CATALOG_INDEX_IMAGE, CHART_VERSION, PLAYWRIGHT_VERSION) to rhdh-plugin-export-overlays step-registry steps and their data-router reporting step. Assisted-by: Claude Code Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * ci: add missing export for IMAGE_REPO IMAGE_REGISTRY QUAY_REPO in upgrade nightly Adds the export statement after image resolution in ocp-helm-upgrade-nightly-commands.sh to match the pattern in ocp-helm-commands.sh for consistency. Assisted-by: Claude Code Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: https://redhat.atlassian.net/browse/RHIDP-14348
Summary
Add Gangway API override support for catalog index image and Helm chart version to all RHDH and overlay E2E test steps.
This enables RC and GA verification via Gangway API triggers with overrides like:
Changes
RHDH steps
commands.sh(+ 4 operator symlinks): Add variable init, export, and override blocks forCATALOG_INDEX_IMAGE,CHART_VERSIONref.yaml: DeclareMULTISTAGE_PARAM_OVERRIDE_CATALOG_INDEX_IMAGEandMULTISTAGE_PARAM_OVERRIDE_CHART_VERSIONsend/data-routercommands.sh: Add new vars toOVERRIDE_VARSarray (skips reporting on Gangway-triggered runs)send/data-routerref.yaml: Declare the new env varsrhdh-plugin-export-overlays steps
ocp/helmcommands.sh: Add variable init, export, override blocks forCATALOG_INDEX_IMAGE,PLAYWRIGHT_VERSIONocp/helmref.yaml: DeclareMULTISTAGE_PARAM_OVERRIDE_CATALOG_INDEX_IMAGEandMULTISTAGE_PARAM_OVERRIDE_PLAYWRIGHT_VERSIONsend/data-routercommands.sh: Add new vars toOVERRIDE_VARSarraysend/data-routerref.yaml: Declare the new env varsCompanion PR
Summary by CodeRabbit
This PR adds Gangway API override support to the Red Hat Developer Hub (RHDH) CI pipelines so operators can trigger RC/GA verification runs with custom plugin catalog index images and (where applicable) Helm chart versions.
What changed (practical impact)
Implementation summary
Review notes, issues & recommendations
Impact & compatibility