[WIP] TRT-2741: Add verify-migrations presubmit for openshift/sippy by mstaeble · Pull Request #81301 · openshift/release

mstaeble · 2026-06-30T23:29:41Z

Summary

Adds a verify-migrations presubmit job for openshift/sippy that runs make verify-migrations
Only triggers on PRs that change files under pkg/db/migrations/
The verify-migrations target checks a migration manifest for sequential numbering, no duplicate versions, and matching up/down SQL files
Companion to TRT-2741: Expand variant keys and decouple daily summaries from variant_combination_id sippy#3722 which adds the manifest and make target

🤖 Generated with Claude Code

Summary by CodeRabbit

This update adds a new verify-migrations presubmit step to the OpenShift CI configuration for openshift/sippy (ci-operator/config/openshift/sippy/openshift-sippy-main.yaml). It runs HOME=/tmp make verify-migrations in the src container and is only triggered when a PR modifies files under pkg/db/migrations/, so migration validation happens automatically at review time.

In practice, this helps prevent bad migration manifests from merging by checking that migration versions are sequential, that versions aren’t duplicated, and that each migration has matching up/down SQL files.

openshift-ci · 2026-06-30T23:29:45Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

openshift-ci-robot · 2026-06-30T23:29:45Z

@mstaeble: This pull request references TRT-2741 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

Adds a verify-migrations presubmit job for openshift/sippy that runs make verify-migrations

Only triggers on PRs that change files under pkg/db/migrations/

The verify-migrations target checks a migration manifest for sequential numbering, no duplicate versions, and matching up/down SQL files

Companion to TRT-2741: Expand variant keys and decouple daily summaries from variant_combination_id sippy#3722 which adds the manifest and make target

@coderabbitai ignore

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-06-30T23:29:59Z

Tip

For best results, initiate chat on the files or code changes.

This comment is an automated notice from openshift-ci-robot (jira-lifecycle-plugin) about a Jira target-version validation warning for TRT-2741, and isn't a request directed at me. Since the PR description includes @coderabbitai ignore, I won't be performing a review or taking any action on this PR.

mstaeble · 2026-06-30T23:39:34Z

@coderabbitai review

coderabbitai · 2026-06-30T23:39:40Z

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

coderabbitai · 2026-06-30T23:39:58Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 129a30d8-7ac8-4fa0-9595-94d913674984

📥 Commits

Reviewing files that changed from the base of the PR and between aecc79c and 120b6c6.

⛔ Files ignored due to path filters (1)

ci-operator/jobs/openshift/sippy/openshift-sippy-main-presubmits.yaml is excluded by !ci-operator/jobs/**

📒 Files selected for processing (1)

ci-operator/config/openshift/sippy/openshift-sippy-main.yaml

🚧 Files skipped from review as they are similar to previous changes (1)

ci-operator/config/openshift/sippy/openshift-sippy-main.yaml

Walkthrough

Adds a new verify-migrations test step to the OpenShift Sippy CI configuration. The step runs make verify-migrations in the src container and is conditionally triggered only when files under pkg/db/migrations/ change.

Changes

CI Configuration Update

Layer / File(s)	Summary
Add verify-migrations test step `ci-operator/config/openshift/sippy/openshift-sippy-main.yaml`	New CI step `verify-migrations` runs `HOME=/tmp make verify-migrations` in the `src` container, conditionally triggered when `pkg/db/migrations/` paths change.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: adding a verify-migrations presubmit for openshift/sippy.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR only adds a CI presubmit YAML step; no Ginkgo test files or titles were modified.
Test Structure And Quality	✅ Passed	PR only modifies a ci-operator YAML presubmit for openshift/sippy; it doesn't touch Ginkgo test code, so this check is not applicable.
Microshift Test Compatibility	✅ Passed	Only CI config changed; no new Ginkgo e2e tests or MicroShift-sensitive API usage were added, so the MicroShift check is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	Only a ci-operator YAML presubmit was added; no new Ginkgo e2e tests or SNO-sensitive assertions appear in the diff.
Topology-Aware Scheduling Compatibility	✅ Passed	Only a ci-operator presubmit step was added; no deployment manifests, controllers, nodeSelectors, affinity, or replica logic were changed.
Ote Binary Stdout Contract	✅ Passed	PR only changes CI YAML; no process-level binary code or stdout writes are introduced.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	Only a CI presubmit step was added; no new Ginkgo e2e tests or network/IP-sensitive test code appears in the change.
No-Weak-Crypto	✅ Passed	The PR modifies only a CI configuration file adding a test job that runs `make verify-migrations`. No weak cryptography patterns (MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB) are present.
Container-Privileges	✅ Passed	The added verify-migrations step uses the src container and the touched YAML contains no privileged/host* / SYS_ADMIN / allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs	✅ Passed	The only change adds a presubmit step running `HOME=/tmp make verify-migrations`; no logging, secrets, or PII exposure appears in the edited YAML.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@ci-operator/config/openshift/sippy/openshift-sippy-main.yaml`:
- Around line 50-54: The new verify-migrations job has been added to the
ci-operator config, but the generated Prow job definitions are not updated yet.
Regenerate the ci-operator jobs so
`pull-ci-openshift-sippy-main-verify-migrations` is emitted, and commit the
resulting changes in the generated jobs alongside the existing
`verify-migrations` config entry.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: dcf0b88d-e17d-47a6-b0c5-3a88a8bd0771

📥 Commits

Reviewing files that changed from the base of the PR and between 429e5eb and aecc79c.

📒 Files selected for processing (1)

ci-operator/config/openshift/sippy/openshift-sippy-main.yaml

Run `make verify-migrations` on PRs that touch migration files. This checks the migration manifest for sequential numbering, no duplicates, and matching up/down SQL files. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

openshift-ci · 2026-06-30T23:57:18Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mstaeble
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 30, 2026

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 30, 2026

openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 30, 2026

coderabbitai Bot reviewed Jun 30, 2026

View reviewed changes

Comment thread ci-operator/config/openshift/sippy/openshift-sippy-main.yaml

mstaeble force-pushed the sippy-verify-migrations branch from aecc79c to 120b6c6 Compare June 30, 2026 23:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[WIP] TRT-2741: Add verify-migrations presubmit for openshift/sippy#81301

[WIP] TRT-2741: Add verify-migrations presubmit for openshift/sippy#81301
mstaeble wants to merge 1 commit into
openshift:mainfrom
mstaeble:sippy-verify-migrations

mstaeble commented Jun 30, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

openshift-ci Bot commented Jun 30, 2026

Uh oh!

openshift-ci-robot commented Jun 30, 2026 •

edited by atlassian Bot

Loading

Summary

Uh oh!

coderabbitai Bot commented Jun 30, 2026 •

edited by atlassian Bot

Loading

Uh oh!

mstaeble commented Jun 30, 2026

Uh oh!

coderabbitai Bot commented Jun 30, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Jun 30, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

openshift-ci Bot commented Jun 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

mstaeble commented Jun 30, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Summary by CodeRabbit

Uh oh!

openshift-ci Bot commented Jun 30, 2026

Uh oh!

openshift-ci-robot commented Jun 30, 2026 • edited by atlassian Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

coderabbitai Bot commented Jun 30, 2026 • edited by atlassian Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mstaeble commented Jun 30, 2026

Uh oh!

coderabbitai Bot commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

openshift-ci Bot commented Jun 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mstaeble commented Jun 30, 2026 •

edited by coderabbitai Bot

Loading

openshift-ci-robot commented Jun 30, 2026 •

edited by atlassian Bot

Loading

coderabbitai Bot commented Jun 30, 2026 •

edited by atlassian Bot

Loading

coderabbitai Bot commented Jun 30, 2026 •

edited

Loading

coderabbitai Bot commented Jun 30, 2026 •

edited

Loading