Skip to content

CORENET-7230: Update OWNERS file#414

Open
taanyas wants to merge 1 commit into
openshift:mainfrom
taanyas:CORENET-7230
Open

CORENET-7230: Update OWNERS file#414
taanyas wants to merge 1 commit into
openshift:mainfrom
taanyas:CORENET-7230

Conversation

@taanyas

@taanyas taanyas commented Jun 8, 2026

Copy link
Copy Markdown

Update OWNERS file - remove inactive members, add current team members.

Removed: aneeshkp, dougbtv, zshi-redhat, s1061123, pliurh
Added: LionelJouin, danwinship, SchSeba, taanyas, raphaelvrosa

Jira: https://issues.redhat.com/browse/CORENET-7230

Summary by CodeRabbit

  • Chores
    • Updated the approval and review configuration for the Networking multus component, adjusting the lists of reviewers and approvers.

Signed-off-by: Tanya Singh <tasingh@redhat.com>
@taanyas taanyas requested a review from dougbtv as a code owner June 8, 2026 06:49
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 8, 2026
@openshift-ci-robot

openshift-ci-robot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

@taanyas: This pull request references CORENET-7230 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Update OWNERS file - remove inactive members, add current team members.

Removed: aneeshkp, dougbtv, zshi-redhat, s1061123, pliurh
Added: LionelJouin, danwinship, SchSeba, taanyas, raphaelvrosa

Jira: https://issues.redhat.com/browse/CORENET-7230

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jun 8, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 70bca3eb-1935-467e-bb01-92d3e7f3e112

📥 Commits

Reviewing files that changed from the base of the PR and between d691040 and 2f0af70.

📒 Files selected for processing (1)
  • OWNERS

Walkthrough

The OWNERS file was updated to modify the reviewers and approvers lists for the Networking/multus component scope. Several existing maintainers were removed and new maintainers, including LionelJouin, danwinship, SchSeba, taanyas, and raphaelvrosa, were added to both lists.

Changes

Networking multus ownership

Layer / File(s) Summary
Update reviewers and approvers for networking multus scope
OWNERS
The reviewers and approvers lists for component: "Networking" / subcomponent: "multus" are updated by removing prior entries and adding new maintainers to the configuration.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error)

Check name Status Explanation Resolution
Stable And Deterministic Test Names ❌ Error Test at ./e2e/e2e_test.go:665 uses fmt.Sprintf with dynamic boolean variable to create test name, violating determinism requirement. Replace fmt.Sprintf with dynamic enableOverlappingRanges variable with static test names like "when enable_overlapping_ranges is enabled" or "when disable_overlapping_ranges is disabled".
✅ Passed checks (14 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title references a Jira ticket and accurately describes the main change: updating the OWNERS configuration file with new and removed team members.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Test Structure And Quality ✅ Passed PR only modifies OWNERS configuration file; no test code changes present, so test quality check is not applicable to this PR.
Microshift Test Compatibility ✅ Passed Ginkgo e2e tests use only standard Kubernetes APIs and whereabouts CRDs. No OpenShift-specific APIs or prohibited namespaces referenced. Tests are MicroShift-compatible.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only updates OWNERS file; no new Ginkgo e2e tests or test code added, so SNO compatibility check does not apply.
Topology-Aware Scheduling Compatibility ✅ Passed PR only modifies OWNERS configuration file; no deployment manifests, operator code, or controller changes that would introduce scheduling constraints.
Ote Binary Stdout Contract ✅ Passed PR only modifies OWNERS configuration file; custom check for OTE binary stdout contract applies only to executable code with process-level functions, not configuration files.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR only updates the OWNERS file (removing/adding reviewers and approvers), with no new Ginkgo e2e tests added. The custom check only applies to new Ginkgo tests.
No-Weak-Crypto ✅ Passed PR does not introduce weak crypto algorithms (MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB), custom crypto implementations, or non-constant-time secret comparisons in main source code.
Container-Privileges ✅ Passed PR only modifies OWNERS configuration file, not container/K8s manifests. The container-privileges check is inapplicable to ownership configuration updates.
No-Sensitive-Data-In-Logs ✅ Passed PR updates OWNERS file and codebase. Code logging intentionally filters sensitive fields during JSON unmarshaling, preventing password/token exposure in %+v logs.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from maiqueb and s1061123 June 8, 2026 06:49
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2026

@raphaelvrosa raphaelvrosa left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2026
@openshift-ci

openshift-ci Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maiqueb, raphaelvrosa, taanyas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

@taanyas: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws 2f0af70 link true /test e2e-aws

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants