Skip to content

Fix: Ensure footer links work across all pages#331

Open
sresandhya wants to merge 2 commits intoopensource-society:mainfrom
sresandhya:fix-footer-links
Open

Fix: Ensure footer links work across all pages#331
sresandhya wants to merge 2 commits intoopensource-society:mainfrom
sresandhya:fix-footer-links

Conversation

@sresandhya
Copy link

No description provided.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR addresses broken footer links across the CodeClip application by updating them to use absolute paths with the /CodeClip/ prefix. The changes are specifically made to fix navigation issues that occur when the site is deployed on GitHub Pages, where the repository name becomes part of the URL path structure.

The main changes include:

  • Converting footer navigation links from relative paths (like / for home) to absolute paths with the /CodeClip/ prefix (e.g., /CodeClip/index.html)
  • Replacing placeholder community links (#) with actual URLs for GitHub, Discord, and Twitter
  • Ensuring consistent path structure for footer links to work properly in the hosted environment

This change fits into the broader codebase architecture by addressing a common deployment concern. The CodeClip application is designed to be hosted on GitHub Pages, which serves repositories at a subpath (username.github.io/CodeClip/). Without proper absolute paths, navigation would break when users try to access different pages from the footer links.

Confidence score: 2/5

  • This PR has significant issues that need to be addressed before merging, particularly HTML structure problems and navigation inconsistencies.
  • The score is low due to invalid HTML structure in the community section where anchor tags are placed directly inside a <ul> element without <li> wrappers, and inconsistent navigation paths between header and footer.
  • The pages/challenges.html file needs more attention to fix the HTML structure issues and ensure navigation consistency across the entire page.

1 file reviewed, 1 comment

Edit Code Review Bot Settings | Greptile

@sresandhya
Copy link
Author

Hi! I've fixed the HTML structure issues and updated the community links using proper

  • elements as per the bot's feedback. Kindly re-run the Greptile check if needed. Let me know if anything else needs to be addressed. Thank you!

  • Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    1 participant