Skip to content

Fix: Added placeholder URLs to footer links#353

Open
AKDev32 wants to merge 2 commits intoopensource-society:mainfrom
AKDev32:fixes/change-placeholder
Open

Fix: Added placeholder URLs to footer links#353
AKDev32 wants to merge 2 commits intoopensource-society:mainfrom
AKDev32:fixes/change-placeholder

Conversation

@AKDev32
Copy link

@AKDev32 AKDev32 commented Jul 31, 2025

🛠️ What This PR Does

This pull request resolves Issue #79 by:

  • Updating the footer navigation links to use proper route-based URLs such as /home, /about, /contact, etc.
  • Improves the user experience by ensuring all footer links are functional and ready for future routing integration.

🔧 Changes Made

  • Replaced placeholder or empty href attributes with meaningful route paths:
    • /home
    • /challenges
    • /leaderboard
    • /about
    • /contact
  • Ensured consistency in structure and formatting across all list items in the footer.

📸 Videos


Footer links now have functional route URLs (e.g., <a href="/about">About</a>)

Recording.2025-08-01.162259.mp4

🧪 How This Was Tested

  • Launched the project locally using the Live Server extension in Visual Studio Code.
  • Automatically opened the site at http://127.0.0.1:5500/ (or similar).
  • Navigated to the footer section and clicked each updated navigation link:
    • /home
    • /challenges
    • /leaderboard
    • /about
  • Verified that:
    • All links now respond to clicks instead of being inactive.
    • Links either navigate correctly or open placeholder pages.
    • There are no JavaScript errors or dead links in the browser console.
    • Page layout and styling remained consistent after the update.

🧩 Fixes

Closes: #79


🏷️ Labels Suggested (for Maintainers)

  • gssoc2025
  • good first issue
  • frontend
  • bug
  • html

🧠 Additional Notes

All updates are limited to the footer component. These changes do not affect page routing logic but prepare the site for seamless integration with internal navigation routes in the future.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR updates the footer navigation links in index.html from anchor-based internal navigation (like #homeSection) to route-based URLs (like /home, /challenges, /leaderboard, /about). The change aims to resolve Issue #79 where footer links were non-functional.

The modification aligns with the application's Router class implementation found in app.js, which defines routes for different pages. However, this creates a navigation inconsistency within the application - the main navigation bar still uses anchor links for single-page navigation (#homeSection, #challengeSection, etc.), while the footer now uses route-based URLs. This means users will experience different navigation behaviors depending on whether they click main nav or footer links.

The CodeClip application appears to be primarily a single-page application with sections that can be navigated via anchors, but it also has a routing system for separate pages like the code editor and profile pages. This change prepares the footer for integration with the routing system but may break the current user experience where footer links should scroll to corresponding sections on the same page.

Confidence score: 2/5

  • This PR introduces navigation inconsistencies that may confuse users and break expected behavior
  • The score reflects concerns about route mismatches (e.g., /leaderboard route may not exist) and the disconnect between main nav anchor behavior and footer route behavior
  • The index.html file needs attention to ensure routing consistency and verify that all new routes are properly handled by the Router class

1 file reviewed, 2 comments

Edit Code Review Bot Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant