fix: respect SERVER_TRANSPORT env var instead of hardcoding stdio#8
Open
grubmeshi wants to merge 1 commit into
Open
fix: respect SERVER_TRANSPORT env var instead of hardcoding stdio#8grubmeshi wants to merge 1 commit into
grubmeshi wants to merge 1 commit into
Conversation
The server start() method was hardcoded to always use stdio transport, ignoring the SERVER_TRANSPORT, SERVER_HTTP_PORT, and SERVER_HTTP_HOST environment variables that were documented in the README. Changes: - Read transport mode from config.server.transport (which is populated from SERVER_TRANSPORT env var by ConfigLoader) - Support 'stdio', 'http', and 'both' transport modes - Add HTTP/SSE server with /sse, /messages, and /health endpoints - Properly stop HTTP server on shutdown Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The server
start()method was hardcoded to always use stdio transport, ignoring theSERVER_TRANSPORT,SERVER_HTTP_PORT, andSERVER_HTTP_HOSTenvironment variables that were documented in the README.Changes
config.server.transport(populated fromSERVER_TRANSPORTenv var by ConfigLoader)stdio,http, andbothtransport modes as documented/sse,/messages, and/healthendpointsTesting