Members: allow user to choose what to sort by#410
Conversation
chadwhitacre
left a comment
chadwhitacre
left a comment
There was a problem hiding this comment.
Ooh! I was thinking we would make it optional, if I'm reading this right it changes the sort from one to the other but the viewer can't chose, correct?
vladh
force-pushed
the
vladh/sort-members-by-date-joined
branch
from
e1d76f4 to
cb39871
Compare
vladh
force-pushed
the
vladh/sort-members-by-date-joined
branch
3 times, most recently
from
ee4e104 to
6048def
Compare
|
@chadwhitacre Got it! This is now ready for review. The user can now select what to sort by. 🎉 Staging deployment: https://osp-staging.vlad.website/members/ Desktop
Mobile
|
vladh
changed the title
chadwhitacre
left a comment
chadwhitacre
left a comment
There was a problem hiding this comment.
Yay! Should we add the date itself in the UI?
|
Another follow on would be asc/desc |
|
I'm afraid that adding the date to the cards will make them too cluttered…but I can try it! Can absolutely add asc/desc to the sort if you think it's useful — doing that now. |
vladh
force-pushed
the
vladh/sort-members-by-date-joined
branch
from
6048def to
74ac790
Compare
|
@chadwhitacre I've added ascending and descending sorting:
I have not added the member join date to the UI of the member list. Adding it would make the card view cluttered, and it just won't fit in the table, especially on mobile. Instead, I've added the join date to the individual member pages:
What do you think? Happy to do any tweaks you'd like, otherwise this is good to merge whenever. |
ScreenRecording_05-16-2025.14-27-01_1.mp4 |
2 participants
Staging deployment: https://osp-staging.vlad.website/members/