Adding initial support for Eviden Trustway HSM#162
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mauricioharley The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
Signed-off-by: Mauricio Harley <mharley@redhat.com>
mauricioharley
changed the title
mauricioharley
changed the title
Signed-off-by: Mauricio Harley <mharley@redhat.com>
Signed-off-by: Mauricio Harley <mharley@redhat.com>
| spec: | ||
| description: BarbicanAPISpec defines the desired state of BarbicanAPI | ||
| properties: | ||
| clientCertificate: |
There was a problem hiding this comment.
Maybe we should consider grouping these into their own key. e.g.
spec:
...
properties:
pkcs11:
clientCertificate: $CERT_CONTENTS_HERE
There was a problem hiding this comment.
Got it. $CERT_CONTENTS_HERE will receive the OpenShift secret name that actually stores the certificate.
This file was automatically generated by a pre-commit hook. I'll check how this could be translated into the specification file.
vakwetu
left a comment
vakwetu
left a comment
There was a problem hiding this comment.
There are a whole bunch of changes here which are for the CRD, for which we decided to do differently in the lunasa patch. I had thought that this PR had been modified to only contain the scripts. But I still see them here.
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3 participants
The shell script automates the necessary steps to include Eviden's Trustway HSM (Hardware Security Module) client software into the container images for Barbican API and Barbican Worker.
The code is the initial support spec to include the same vendor and product.