Skip to content

[18.0-fr5] [dataplane_adoption] Do not override images in the nodeset#1344

Open
openshift-cherrypick-robot wants to merge 2 commits intoopenstack-k8s-operators:18.0-fr5from
openshift-cherrypick-robot:cherry-pick-1288-to-18.0-fr5
Open

[18.0-fr5] [dataplane_adoption] Do not override images in the nodeset#1344
openshift-cherrypick-robot wants to merge 2 commits intoopenstack-k8s-operators:18.0-fr5from
openshift-cherrypick-robot:cherry-pick-1288-to-18.0-fr5

Conversation

@openshift-cherrypick-robot
Copy link
Copy Markdown

@openshift-cherrypick-robot openshift-cherrypick-robot commented Apr 2, 2026

This is an automated cherry-pick of #1288

/assign ciecierski

@karelyatin
Do not override images in the nodeset
fff98e5 
OpenstackVersion CR have info for all the images, we
should utilize that instead of overriding in the nodeset.
Any image overrides in nodeset has highest priority so
any handling/overrides with OpenstackVersion CR is not
used.

Also added edpmNodeExporterImage which was missing in
OpenstackVersion template.

Signed-off-by: Yatin Karel <ykarel@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 2, 2026
Merged
@karelyatin
Copy link
Copy Markdown
Contributor

karelyatin commented Apr 8, 2026

we need to hold this as some indentation issue is noticed so we need to fix that first:-
swiftProxyImage:
edpmNodeExporterImage:

I think when i tested that i didn't had node exporter image set

@karelyatin
[dataplane_adoption] Fix indentation issue in OpenStackVersion CR
217db89 
Issue introduced in [1], this patch fixes it.

[1] openstack-k8s-operators#1288

(cherry picked from commit aafc5cc)
@karelyatin
Copy link
Copy Markdown
Contributor

karelyatin commented Apr 8, 2026

we need to hold this as some indentation issue is noticed so we need to fix that first:- swiftProxyImage: edpmNodeExporterImage:

I think when i tested that i didn't had node exporter image set

Included fix commit in the PR

jistr
jistr approved these changes Apr 15, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@jistr jistr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm label Apr 15, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 15, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jistr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jistr jistr removed the approved label Apr 16, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 2, 2026

This PR is stale because it has been for over 15 days with no activity.
Remove stale label or comment or this PR will be closed in 7 days.

@github-actions github-actions Bot added the Stale label May 2, 2026
@jistr jistr removed the Stale label May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jistr jistr jistr approved these changes

Assignees

@jistr jistr

@ciecierski ciecierski

Labels

do-not-merge/hold lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@openshift-cherrypick-robot @karelyatin @jistr @ciecierski