Fix neutron-adoption with ironic

[gthiemonge]

Fix a conversion issue in neutron-adoption, the task triggers a bug:

[..]
oc patch openstackcontrolplane openstack --type=merge --patch '{'spec': {'neutron': {'template': {'ml2MechanismDrivers': ['ovn', 'baremetal']}}}}' Error from server (BadRequest): error decoding patch: invalid character 's' looking for beginning of object key string [..]

ironic_ml2_baremetal_patch is an ansible object, it needs to be converted to a json string before it's used in an oc patch command

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jistr for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gthiemonge]

@hjensas ^ FYI I'm testing it in a D/S CI job

[jistr]

I guess it's a problem of single quotes within single quotes, and to_json makes double quotes instead. (json.dumps does that and according to docs, the filter uses that function under the hood)

So this is not resilient to single quotes appearing inside the patch in a string, but since this is testing only, i think it's ok and should fix the mentioned problem.

/lgtm

[gthiemonge]

I guess it's a problem of single quotes within single quotes, and to_json makes double quotes instead. (json.dumps does that and according to docs, the filter uses that function under the hood)

So this is not resilient to single quotes appearing inside the patch in a string, but since this is testing only, i think it's ok and should fix the mentioned problem.

/lgtm

another method would be the use of raw text that represents a yaml doc, for instance for neutron_config_patch:

data-plane-adoption/tests/roles/neutron_adoption/defaults/main.yaml

Line 2 in c76f080

neutron_config_patch: |