Skip to content

Replace hardcoded NS in KUTTL with variable#453

Open
abays wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
abays:kuttl_ns_fix
Open

Replace hardcoded NS in KUTTL with variable#453
abays wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
abays:kuttl_ns_fix

Conversation

@abays
Copy link
Copy Markdown
Contributor

@abays abays commented Apr 23, 2026

DESIGNATE_KUTTL_NAMESPACE is user-configurable in install_yamls (via ?= assignment), but test scripts and asserts had "designate-kuttl-tests" hardcoded in databaseHostname assertions. Tests would fail when run with a non-default namespace.

Replace all hardcoded namespace references with the $NAMESPACE env var that KUTTL provides to test scripts. Specifically, for databaseHostname validation, switch from static YAML asserts to script-based checks that dynamically construct the expected value.

Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com

@openshift-ci openshift-ci Bot requested review from gthiemonge and karelyatin April 23, 2026 10:56
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 23, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abays abays requested a review from omersch381 April 23, 2026 10:56
@abays
Copy link
Copy Markdown
Contributor Author

abays commented Apr 23, 2026

/test functional

@abays
Copy link
Copy Markdown
Contributor Author

abays commented Apr 23, 2026

@abays: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
Test name Commit Details Required Rerun command
ci/prow/functional 064fe88 link true /test functional
ci/prow/designate-operator-build-deploy-kuttl 064fe88 link true /test designate-operator-build-deploy-kuttl

Full PR test history. Your PR dashboard.
Details

KUTTL failure does not seem related to this PR's particular KUTTL changes, but might be:

case.go:380: command "tupleTemplate='{{ range (index .spec.template.spec.containers 0).en..." exceeded 2 sec timeout, context deadline exceeded

Will try again and see what happens.

/test designate-operator-build-deploy-kuttl

@abays abays requested a review from beagles April 24, 2026 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant