Skip to content

Add parameter to customize the number of manilaAPI processes#371

Closed
fmount wants to merge 1 commit into
openstack-k8s-operators:mainfrom
fmount:workers
Closed

Add parameter to customize the number of manilaAPI processes#371
fmount wants to merge 1 commit into
openstack-k8s-operators:mainfrom
fmount:workers

Conversation

@fmount

@fmount fmount commented Dec 5, 2024

Copy link
Copy Markdown
Collaborator

No description provided.

@openshift-ci openshift-ci Bot requested review from abays and viroel December 5, 2024 08:07
@openshift-ci

openshift-ci Bot commented Dec 5, 2024

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fmount

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fmount

fmount commented Dec 5, 2024

Copy link
Copy Markdown
Collaborator Author

/test manila-operator-build-deploy-kuttl

type: string
type: object
workers:
default: 3

@fmount fmount Dec 5, 2024

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gouthampacha is this a good "default" ? Do we want to stay w/ 4 (the original hardcoded value), or do we want something else?
Restored 4 as default. Do we want a different value?

@stuggi

stuggi commented Dec 5, 2024

Copy link
Copy Markdown
Contributor

I am against adding a parameter for something you can use the custom config way to set it. we do not want to introduce tht params

@stuggi

stuggi commented Dec 5, 2024

Copy link
Copy Markdown
Contributor

I am against adding a parameter for something you can use the custom config way to set it. we do not want to introduce tht params

ok, wait this is different. this is for httpd customization

@stuggi

stuggi commented Dec 5, 2024

Copy link
Copy Markdown
Contributor

form httpd tuning, check this keystone PR openstack-k8s-operators/keystone-operator#500 . we should do the same here

@fmount fmount force-pushed the workers branch 2 times, most recently from 14b46b2 to 55cc6a9 Compare December 5, 2024 10:37
Signed-off-by: Francesco Pantano <fpantano@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants