Set service_type in [keystone_authtoken] for access rule validation#589
Conversation
Without service_type configured, keystonemiddleware cannot validate application credentials with custom access rules, causing HTTP 401 for end users. Closes: OSPRH-22365 Signed-off-by: Veronika Fisarova <vfisarov@redhat.com>
| project_name = service | ||
| {{- end }} | ||
| interface = internal | ||
| service_type = sharev2 |
There was a problem hiding this comment.
Is this something we should propagate via templateParameters? I'm basically wondering if we should propagate [1] because for manila we have
- sharev1: enabled in 18 but deprecated
- sharev2: both 18 and 19, but in 19 it might have a different name and it would be good to keep the manila-operator as the single source of truth [2]
[1] https://github.com/openstack-k8s-operators/manila-operator/blob/main/internal/manila/const.go#L31
[2] https://github.com/openstack-k8s-operators/manila-operator/blob/main/internal/controller/manilaapi_controller.go#L630
There was a problem hiding this comment.
/lgtm as discussed let's hardcode based on https://opendev.org/openstack/service-types-authority/src/branch/master/service-types.yaml and to keep consistency across the board.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Deydra71, fmount The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
Bot
merged commit 025e8c8
into
openstack-k8s-operators:main
|
/cherry-pick 18.0-fr6 |
|
@Deydra71: new pull request created: #593 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3 participants
Without service_type configured, keystonemiddleware cannot validate application credentials with custom access rules, causing HTTP 401 for end users.
Closes: OSPRH-22365