Skip to content

2221 public approved repos#625

Open
TylerZeroMaster wants to merge 15 commits into
mainfrom
2221-public-approved-repos
Open

2221 public approved repos#625
TylerZeroMaster wants to merge 15 commits into
mainfrom
2221-public-approved-repos

Conversation

@TylerZeroMaster
Copy link
Copy Markdown
Contributor

@TylerZeroMaster TylerZeroMaster commented Jun 27, 2024

part of openstax/ce#2221

  • Makes process.env.STACK_NAME available in frontend (see rollup config)
  • Only allows making repositories public if the stack is deployed in production (determined by STACK_NAME)
  • In production, when a book is added to the ABL
    • If it is not public, the user will be asked if they would like to make it public
      • If they would like to make it public, they will need to type public into a prompt
        • If they do not, then the approve process is (silently) aborted
        • If they do, then the backend will attempt to make the repository public by setting private to false in the repository's settings.yml (using the user's token)
      • If they do not wish to make it public, then the approve process behaves like before
    • If the repository is already public, the user will not be prompted
  • Outside of production, the user should never have the option to make a repository public and the backend will raise an error if they try

Remaining changes are primarily related to improving tests.

@TylerZeroMaster
backend - Add visibility to GitHubRepo; simplify process of adding ne…
cbd4aaa 
…w fields

The new GraphQLModel class has methods that simplify conversion to/from graphql

graphql_query returns a linefeed separated list of the class's fields in camelCase (ready for use in graphql

from_node pulls the fields out of the graphql result
@TylerZeroMaster
backend - Remove unnecessary timestamp transformation
5a98b13 
fromisoformat now parses 'Z' as utc timezone (+00:00)
@TylerZeroMaster
backend - Update test data (also used for mocking in leashed mode)
dd9348b
@TylerZeroMaster
backend - Add tests for push_to_github
c4661fc 
api.py: Use `content` instead of `data` for string value
`data` is only supposed to be used for dictionaries

Improve mock http client
@TylerZeroMaster
backend - Add endpoint to get information about a book repository
2256279
@TylerZeroMaster
backend - Add make_repo_public to github api
de7d225 
Add tests as well
@TylerZeroMaster
frontend - Make STACK_NAME available to frontend
16677c1 
This helps the frontend know where it is deployed (prod, staging, etc.)
@TylerZeroMaster
frontend - Add config to frontend that can store configuration inform…
49d42d8 
…ation

Update the backend config to be more similar to frontend
@TylerZeroMaster
backend - Support making repository public on approval
728f379
@TylerZeroMaster
frontend - Add tests for config
2036992
@TylerZeroMaster
frontend - Support making repository public on approval
43f3ecc 
Fix some questionable types in fetchABL
@TylerZeroMaster
frontend - Add buildURL utility; fix abl tests
bbdcc7e
@TylerZeroMaster
frontend - Add tests for getBookRepository
5525f71 
Add type for bookr repository response
@TylerZeroMaster
backend - improve error message for unexpected 'private' value
058aef5 
Maybe it is a string? If that is true, it is not valid
@TylerZeroMaster TylerZeroMaster requested a review from a team June 27, 2024 14:48
@TylerZeroMaster TylerZeroMaster self-assigned this Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@TylerZeroMaster TylerZeroMaster

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@TylerZeroMaster