CORE-2241 Fixed parsing of spreadsheet rows with italics etc#444
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes spreadsheet import parsing for rich-text Excel cells by removing Roo’s outer <html>...</html> wrapper before Kramdown parses the cell content, preserving surrounding plain text and inline formatting.
Changes:
- Normalizes spreadsheet cell values by stripping Roo’s rich-text
<html>wrapper. - Expands the assessment import spec fixture expectations from 3 to 4 exercises.
- Adds assertions that italicized rich-text content is preserved in imported stems and answers.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
app/routines/process_spreadsheet.rb |
Strips Roo-generated outer HTML wrappers from normalized cell values before downstream parsing. |
spec/routines/exercises/import/assessments_spec.rb |
Updates import expectations and verifies italicized spreadsheet content is imported correctly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jivey
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://openstax.atlassian.net/browse/CORE-2241
The parsing was broken when the row contained italics (only the italics content was returned). This was because Roo would make the content something like
<html>Some <i>italics</i> text</html>Kramdown would discard everything besides the italics. The solution is to strip out the html tags.