Merged
Conversation
So calling plog.Logger.WithPrefix() to prepare a new logger to assign would change the original logger, which is inconsistent with Attr().
ClusterConfigUpdated triggered a NodeConfigUpdated in case the node config defaults to cluster config values. Detect when the node config data did change and skip publication.
To replace this ugly pattern:
prefix := log.Prefix() + "foo: "
log := log.WithPrefix(prefix)
With simpler:
log := log.AddPrefix("foo: ")
This prefix is hard to get right, so implement here and optimise the strings manipulation for performance.
* remove undue gommon import * remove log entries Attributes that are not index * make sure we log the reason for unschedule and reschedule * remove eventJobRun, no need to make this async * better log prefix
So the scheduler is notified of schedules changes. Also fix a undue reschedule message on daemon start for tasks requiring a joinable collector.
Replace LastRunFile and LastSuccessFile fields by a single StatefileKey and 2 type functions: * schedule.Entry.LastRunFile() * schedule.Entry.LastSuccessFile() Use pointer receivers for all schedule.Entry functions. Add omitempty to the Require field.
Unduly switched to Trace level.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.