Move the labels from node.Status to node.Config#983
Merged
cgalibern merged 6 commits intoopensvc:mainfrom Feb 20, 2026
Merged
Conversation
Member
cvaroqui
commented
Feb 19, 2026
cvaroqui
commented
- drop useless node.Node.Labels()
- log san paths and labels changes
- don't log icfg refreshs at info level (flooding logs)
* drop useless node.Node.Labels() * log san paths and labels changes * don't log icfg refreshs at info level (flooding logs)
* Add the hooks to node.Config * Detect the hooks config change when decide to fire a NodeConfigUpdated event * Move output.Flatten to flatten.Flatten as the data flattening is used for more than the output renderer (e.g. in logs) * Rename node.Config.Equals to node.Config.Equal (aligned with Equal functions in the golang core) Example: $ bin/om cluster config show --section hook#1 [hook#1] events = HeartbeatAlive HeartbeatStale command = env | tee /tmp/hook1.txt $ bin/om daemon status -o flat | grep hook cluster.node.dev2n1.config.hooks[0].command[0] = "env" cluster.node.dev2n1.config.hooks[0].command[1] = "|" cluster.node.dev2n1.config.hooks[0].command[2] = "tee" cluster.node.dev2n1.config.hooks[0].command[3] = "/tmp/hook1.txt" cluster.node.dev2n1.config.hooks[0].events[0] = "HeartbeatAlive" cluster.node.dev2n1.config.hooks[0].events[1] = "HeartbeatStale" cluster.node.dev2n1.config.hooks[0].name = "1" Changes are highlighted precisely in logs: 11:26:49.257 INF daemon: hook: 1: +events[2]="NodeLabelsCommited" 11:26:49.257 INF daemon: hook: 1: stop listening for events [HeartbeatAlive HeartbeatStale NodeLabelsCommited] 11:26:50.054 INF daemon: hook: 1: listening for events [HeartbeatAlive HeartbeatStale]
The scheduler must avoid executing the CRM command when it knows it will produce a max_parallel overflow logged as an error.
Emit NodeConfigUpdated when the collector config changes. Also make the collector daemon subsystem use node.Config.Collector directly to prepare the requester, without having to allocate a object.NewNode() ... the shared function are now all in the core/collector package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.