fix(sdk): Support RSA4096 Kas keys#343
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the SDK's cryptographic capabilities by integrating support for RSA4096 keys. This allows the system to handle stronger encryption standards for Key Access Server (KAS) operations, improving overall security and compatibility with more robust key management practices. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support for RSA 4096 keys by introducing a new KeyType enum value. While the changes in KeyType.java are correct, there are a couple of issues. Firstly, the implementation seems incomplete as the key generation logic in KASClient does not appear to respect the new key size, potentially leading to security issues. Secondly, unit tests have not been added for the new key type. Please see the detailed comments for more information.
X-Test Failure Report✅ go-main |
|
passing test: successful run: https://github.com/opentdf/java-sdk/actions/runs/22634917479/job/65595094337 |
elizabethhealy
changed the title
X-Test Results✅ go-v0.13.0 |
…df/java-sdk into dspx-2517-support-4096-rsa
X-Test Failure Report |
|
/gemini summary |
Summary of ChangesThis pull request primarily enhances the SDK's cryptographic capabilities by introducing comprehensive support for RSA4096 keys, allowing for stronger encryption in Key Access Server (KAS) operations. It also refines the key retrieval process by incorporating Key IDs (KID) for better key management. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
|
|
elizabethhealy
changed the title
X-Test Results✅ go-v0.13.0 |
Java sdk enables rsa 4096 with opentdf/java-sdk#343, passing the tests against this branch Dynamic version check for RSA 4096 support: A new mechanism was introduced in cli.sh to dynamically check if the Java SDK version supports RSA 4096, specifically for versions at or above 0.13.0.
2 participants
This pull request primarily enhances the SDK's cryptographic capabilities by introducing comprehensive support for RSA4096 keys, allowing for stronger encryption in Key Access Server (KAS) operations. It also refines the key retrieval process by incorporating Key IDs (KID) for better key management.
Highlights
RSA4096Keyto theKeyTypeenum and updated its mapping methods (fromAlgorithm,fromPublicKeyAlgorithm) to correctly recognize and handle 4096-bit RSA keys for KAS operations.KeyTypeTestto ensure proper functionality and mapping for the newly introducedRSA4096Key.