chore(ci): tests with additional ec kas#746
Conversation
Summary of ChangesHello @elizabethhealy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request expands the end-to-end test suite by adding new scenarios to validate TDF3 encryption and decryption with different key wrapping algorithms. It also includes necessary cleanup mechanisms to maintain test environment integrity after these new tests are executed. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
X-Test Resultsbats-test-results |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds end-to-end tests for TDF3 roundtrip encryption and decryption using EC P-384 and RSA wrapping. A critical security concern has been identified: the security analysis could not be performed on e2e/encrypt-decrypt.bats because the file content was empty, preventing a full security assessment. Additionally, the review suggests improving maintainability by refactoring duplicated logic in the new test code and the teardown function, which also addresses a potential copy-paste bug.
X-Test Resultsbats-test-results |
X-Test Failure Report |
X-Test Failure Report |
|
failing ec 384 on main: https://github.com/opentdf/otdfctl/actions/runs/21960762007/job/63437259256?pr=746 |
X-Test Failure Report |
|
passing with fix branch: https://github.com/opentdf/otdfctl/actions/runs/21961089217/job/63438435821?pr=746 |
1 participant
No description provided.