chore(ci): fix flaky key mappings pagination test#753
Conversation
Summary of ChangesHello @jakedoublev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a persistent flakiness issue in the end-to-end tests for KAS key mappings pagination. By explicitly passing the KAS registry ID to the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request addresses a flaky key mappings pagination test by explicitly including the --kas flag with the ${KAS_REGISTRY_ID} in the list-mappings commands. This change improves the test's reliability and ensures it targets the correct KAS registry. A trailing blank line was also removed, which is a minor cleanup. The changes are clear and directly resolve the reported flakiness.
X-Test Resultsbats-test-results |
X-Test Resultsbats-test-results |
X-Test Resultsbats-test-results |
2 participants
Updates test to ensure pagination limit/offset flags drive resulting JSON output and are consistent.