fix(core): unsafe update result output values order

[jakedoublev]

Ensure unsafely updating the order of attribute values on a definition is properly reflected in the table output

[gemini-code-assist]

Summary of Changes

Hello @jakedoublev, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where the unsafe update attribute CLI command did not consistently display the immediate post-update state of an attribute, particularly regarding the order of its values and traversal settings. The fix involves enhancing the underlying handler function to return the most current attribute object, which the CLI then uses to render accurate and up-to-date information to the user.

Highlights

• CLI Output Consistency: The unsafe update attribute command now correctly displays the updated state of an attribute immediately after modification, specifically for value order and traversal settings. Previously, the output might not have reflected these changes.
• API Function Enhancement: The UnsafeUpdateAttribute handler function in pkg/handlers/attribute.go was modified to return the fully updated policy.Attribute object, ensuring that subsequent operations or displays use the most current data. Error handling was also adjusted to align with the new return signature.
• End-to-End Test Coverage: A new e2e test was introduced in e2e/attributes.bats to validate that the non-JSON output of the unsafe update command accurately reflects reordered attribute values immediately after the update.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively resolves a correctness issue where the CLI's unsafe update command would display outdated attribute information after an update operation. The UnsafeUpdateAttribute handler now correctly returns the updated attribute, which is then utilized by the CLI to ensure the displayed output accurately reflects the most recent state. This is a good and necessary fix.

[github-actions]

X-Test Results

bats-test-results
test-cases-mapping-report
✅ js-v0.9.0
✅ js-main
✅ java-v0.9.0
✅ java-main
✅ go-v0.9.0
✅ go-main