fix(xtest): Enable extended EC tests for java >= 0.13.0

[elizabethhealy]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the extended test framework to correctly enable cryptographic mechanism tests for Java SDK versions 0.13.0 and newer. It refactors the feature support detection, moving the version-specific logic into the Java CLI script and removing static limitations from the Python test definition file. This ensures that newer Java SDKs can be properly tested for their support of RSA-4096 and specific EC curves.

Highlights

• Java SDK Version Check: Implemented a version check in the Java CLI script (cli.sh) to dynamically determine support for mechanism-rsa-4096 and mechanism-ec-curves-384-521 based on whether the Java SDK version is 0.13.0 or higher.
• Updated Feature Support Logic: Modified the tdfs.py file to remove the hardcoded False for Java support of mechanism-rsa-4096 and mechanism-ec-curves-384-521, allowing the cli.sh script to manage this determination.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• xtest/sdk/java/cli.sh
  • Added a version check for mechanism-rsa-4096 and mechanism-ec-curves-384-521 features, enabling them for Java SDK versions 0.13.0 and above.
• xtest/tdfs.py
  • Removed the explicit False return for Java support of mechanism-rsa-4096.
  • Removed the explicit False return for Java support of mechanism-ec-curves-384-521.

Activity

• No specific activity (comments, reviews, progress) was provided in the context.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[gemini-code-assist]

Code Review

The pull request correctly enables extended EC tests for Java SDK versions greater than or equal to 0.13.0 by updating the cli.sh script to check the Java version for mechanism-rsa-4096 and mechanism-ec-curves-384-521 features. Additionally, the tdfs.py file has been updated to remove explicit return False statements for Java regarding these mechanisms, allowing the cli.sh script to determine support dynamically. The changes are consistent and align with the pull request's objective.

[gemini-code-assist]

The comment currently states "rsa4096 support in >= 0.13.0". However, the case statement also includes mechanism-ec-curves-384-521. Please update the comment to reflect both mechanisms for clarity and accuracy.

Suggested change

	# rsa4096 support in >= 0.13.0
	# rsa4096 and ec-curves-384-521 support in >= 0.13.0

[github-actions]

X-Test Results

✅ js-main
✅ js-v0.13.0
✅ go-main
✅ go-v0.13.0
✅ java-main
✅ java-v0.13.0