-
Notifications
You must be signed in to change notification settings - Fork 48
[border-router] add info about required flag for dongle in OpenThread Border Router Setup guide #195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @jrhodie, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the OpenThread Border Router Setup guide by clarifying a mandatory build flag for nRF52840 USB dongles. The update ensures users are aware of the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds an important note to the OpenThread Border Router setup guide about the required -DOT_BOOTLOADER=USB flag when building firmware for nRF52840 USB dongles. This is a helpful clarification for users. My review includes a suggestion to format this new information as a > Note: block to improve its visibility and maintain consistency with the document's existing style, while also correcting a minor spacing issue.
abtink
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change LGTM. That said, I am not familiar with nRF RCP and its requirements. I suggest someone from Nordic double-check this. I will add/suggest some reviewer @LuDuda .
|
For context @LuDuda , we got feedback internally on openthread.io that said: When building firmware for the nRF52840 USB dongles, you must use the flag -DOT_BOOTLOADER=USB in order to enable the USB DFU trigger. This must be present when building for both the RCP and NCP design. If the flag is not present, the compiled firmware can not be loaded onto the dongle. |
Vyrastas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor nit
|
LGTM for doc update only |
|
@LuDuda - does the wording look ok, thanks? |
LuDuda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR!
I would slightly change the wording to indicate that the primary reason for using this flag is to select the correct memory map (linker script).
Other than this I'm accepting.
jwhui
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 👍🏼
No description provided.