Skip to content

Conversation

@yangsong-cnyn
Copy link
Contributor

@yangsong-cnyn yangsong-cnyn commented Jan 22, 2026

This PR mandates Python 3 virtual environment on host build machine for newer Linux OS (e.g. Debian Trixie ) when installing Python dependencies in bootstrap.bash.

It's to solve the PEP 668 externally-managed-environment error #114

@gemini-code-assist
Copy link

Summary of Changes

Hello @yangsong-cnyn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces changes to the build scripts to enforce the use of Python virtual environments for managing Python dependencies. This change specifically addresses issues encountered on newer Linux distributions related to PEP 668's "externally-managed-environment" policy, ensuring a consistent and isolated environment for Python package installations during the reference release build process.

Highlights

  • Virtual Environment Mandate: The build process now mandates the use of Python virtual environments for installing Python dependencies, addressing the PEP 668 'externally-managed-environment' error on newer Linux distributions.
  • Dependency Installation: The bootstrap.bash script has been updated to ensure python3-venv is installed and to create and utilize a local .venv for pip3 installations if one isn't already active.
  • Environment Activation: The make-reference-release.bash script now includes logic to activate the local virtual environment (.venv) after bootstrapping, ensuring subsequent build steps use the isolated Python environment.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@yangsong-cnyn yangsong-cnyn requested a review from jwhui January 22, 2026 08:35
@yangsong-cnyn
Copy link
Contributor Author

/gemini review

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request mandates the use of a Python virtual environment for installing dependencies, which is an excellent improvement for build isolation and compatibility with newer Linux distributions. The changes to create and use a virtual environment in bootstrap.bash and activate it in make-reference-release.bash are logical and well-executed. I have one suggestion to refactor a small part of the logic to improve maintainability by reducing code duplication.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Copy link

@EskoDijk EskoDijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks & looks good - only one minor comment on indentation.

@jwhui jwhui linked an issue Jan 26, 2026 that may be closed by this pull request
@jwhui jwhui merged commit e68ef2d into openthread:main Jan 26, 2026
3 checks passed
@yangsong-cnyn yangsong-cnyn deleted the bootstrap_venv branch February 5, 2026 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Script make-firmware.bash for Python >= 3.11 and virtual envs

3 participants