-
Notifications
You must be signed in to change notification settings - Fork 30
[script] mandate Python virtual environments for reference release build #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @yangsong-cnyn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces changes to the build scripts to enforce the use of Python virtual environments for managing Python dependencies. This change specifically addresses issues encountered on newer Linux distributions related to PEP 668's "externally-managed-environment" policy, ensuring a consistent and isolated environment for Python package installations during the reference release build process. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request mandates the use of a Python virtual environment for installing dependencies, which is an excellent improvement for build isolation and compatibility with newer Linux distributions. The changes to create and use a virtual environment in bootstrap.bash and activate it in make-reference-release.bash are logical and well-executed. I have one suggestion to refactor a small part of the logic to improve maintainability by reducing code duplication.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
EskoDijk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks & looks good - only one minor comment on indentation.
1017e3b to
6e79baf
Compare
This PR mandates Python 3 virtual environment on host build machine for newer Linux OS (e.g. Debian Trixie ) when installing Python dependencies in
bootstrap.bash.It's to solve the PEP 668
externally-managed-environmenterror #114