Skip to content

fix: fix npm run dev error#401

Merged
kagol merged 1 commit intodevfrom
kagol/fix-npm-run-dev-error
Dec 5, 2025
Merged

fix: fix npm run dev error#401
kagol merged 1 commit intodevfrom
kagol/fix-npm-run-dev-error

Conversation

@kagol
Copy link
Member

@kagol kagol commented Dec 5, 2025

Summary by CodeRabbit

Release Notes

  • Chores
    • Updated environment configuration variables for improved URL prefix handling across deployment environments.
    • Refreshed deployment workflows to align with updated configuration naming conventions.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 5, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request renames the environment variable from VITE_BASEROUTER to VITE_OPENTINY_URL_PREFIX across configuration files, workflow definitions, and component code. The new variable is introduced in environment configuration files and updated in the URL construction logic within the iframe component.

Changes

Cohort / File(s) Summary
Environment Configuration
\.env\.hdesign, \.env\.opentiny
Added new environment variable VITE_OPENTINY_URL_PREFIX with values / and / respectively for URL prefix configuration.
GitHub Workflows
\.github/workflows/deploy-github\.yml, \.github/workflows/deploy-obs\.yml
Renamed build step environment variable from VITE_BASEROUTER to VITE_OPENTINY_URL_PREFIX, maintaining value /tiny-charts/ in both workflow files.
Vue Component
doc/main/example/components/iframe\.vue
Updated updateIframeSrc method to use VITE_OPENTINY_URL_PREFIX instead of VITE_BASEROUTER for iframe source URL construction.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

  • Verify that all references to VITE_BASEROUTER have been replaced with VITE_OPENTINY_URL_PREFIX throughout the codebase
  • Confirm environment variable values are correctly applied across development and production deployment workflows
  • Ensure no orphaned VITE_BASEROUTER references remain in other files or components

Poem

🐰 A variable's new name takes flight,
From BASEROUTER to URL's delight,
Across configs and workflows we hop,
From env to iframe, we don't stop,
Prefixes unified, oh what a sight! ✨

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch kagol/fix-npm-run-dev-error

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f2c2f7d and bb42a0e.

📒 Files selected for processing (5)
  • .env.hdesign (1 hunks)
  • .env.opentiny (1 hunks)
  • .github/workflows/deploy-github.yml (1 hunks)
  • .github/workflows/deploy-obs.yml (1 hunks)
  • doc/main/example/components/iframe.vue (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kagol kagol merged commit be1b9a0 into dev Dec 5, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant