chore(components): upgrade and lock tiptap dependencies to 3.17.1#314
chore(components): upgrade and lock tiptap dependencies to 3.17.1#314SonyLeo wants to merge 3 commits intoopentiny:developfrom
Conversation
WalkthroughThe pull request pins TipTap-related dependencies in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
SonyLeo
force-pushed
the
chore/lock-tiptap-version
branch
from
0f40738 to
e187ba3
Compare
|
✅ Preview build completed successfully!
|
📦 Package Previewpnpm add https://pkg.pr.new/@opentiny/tiny-robot@0221455 pnpm add https://pkg.pr.new/@opentiny/tiny-robot-kit@0221455 pnpm add https://pkg.pr.new/@opentiny/tiny-robot-svgs@0221455 commit: 0221455 |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
packages/components/package.json (1)
69-70: Remove unused Tiptap extensions from dependencies.The
@tiptap/extension-bubble-menuand@tiptap/extension-floating-menupackages are declared in package.json but are not imported or referenced anywhere in the codebase. The sender editor only uses Document, Paragraph, Text, History, Placeholder, and CharacterCount extensions. Removing these unused dependencies will reduce the dependency footprint.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/components/package.json` around lines 69 - 70, Remove the unused Tiptap extension dependencies "@tiptap/extension-bubble-menu" and "@tiptap/extension-floating-menu" from the package.json dependencies block, run your package manager (npm/yarn/pnpm) to update the lockfile and node_modules, and rebuild to ensure nothing else imports them; before committing, search the codebase for references to "@tiptap/extension-bubble-menu" and "@tiptap/extension-floating-menu" to confirm they are unused and run tests to verify no breakage.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/components/package.json`:
- Around line 62-68: Remove the unused top-level dependency "@tiptap/extensions"
from package.json (it is not imported anywhere; individual packages like
"@tiptap/extension-document", "@tiptap/extension-paragraph", etc. are used
instead) to avoid bundle bloat; also review and remove
"@tiptap/extension-bubble-menu" and "@tiptap/extension-floating-menu" from
package.json if those packages are not imported elsewhere or planned for future
use so only actively used `@tiptap/extension-`* packages remain.
---
Nitpick comments:
In `@packages/components/package.json`:
- Around line 69-70: Remove the unused Tiptap extension dependencies
"@tiptap/extension-bubble-menu" and "@tiptap/extension-floating-menu" from the
package.json dependencies block, run your package manager (npm/yarn/pnpm) to
update the lockfile and node_modules, and rebuild to ensure nothing else imports
them; before committing, search the codebase for references to
"@tiptap/extension-bubble-menu" and "@tiptap/extension-floating-menu" to confirm
they are unused and run tests to verify no breakage.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: cc61aff7-25c2-4cfb-8898-780bb33777f6
📒 Files selected for processing (1)
packages/components/package.json
1 participant
背景
修复 Sender 相关 Tiptap 依赖在干净环境和 CI 中漂移到较新版本后导致的构建异常
问题说明
Sender 依赖 Tiptap 相关包。此前依赖使用范围版本，干净安装环境在未固定锁文件的情况下可能解析到较新的
3.20.x版本，进而出现：vue-tsc报Cannot find module '@tiptap/...'变更内容
影响范围
原因：@tiptap/* 已在构建配置中作为 external 处理，不会被打进组件 dist
验证方式
已重点验证以下场景：
Summary by CodeRabbit