Fix span logs and tags while logging with level ERROR#328
Open
xbj110825 wants to merge 2 commits intoopentracing-contrib:masterfrom
Open
Fix span logs and tags while logging with level ERROR#328xbj110825 wants to merge 2 commits intoopentracing-contrib:masterfrom
xbj110825 wants to merge 2 commits intoopentracing-contrib:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While using SpanLogsAppender, we found that while logging with level ERROR, the span log event's value is something like io.opentracing.tag.BooleanTag@7251412f. So i search the behavior of other components(e.g. io.opentracing.contrib.jdbc.JdbcTracingUtils.onError), and found that we should log Tag.ERROR.getKey() instead of Tag.ERROR, and tag error.