UCT/GDRCOPY/UCP: Fix gdr_copy access_mem_types and memtype_ep selection#11372
Open
yosefe wants to merge 5 commits intoopenucx:masterfrom
Open
UCT/GDRCOPY/UCP: Fix gdr_copy access_mem_types and memtype_ep selection#11372yosefe wants to merge 5 commits intoopenucx:masterfrom
yosefe wants to merge 5 commits intoopenucx:masterfrom
Conversation
gdr_copy is able to access source buffer in host memory, not in cuda memory. Fix access_mem_types, and adjuct memtype_ep selection logic.
Contributor
|
Would be good to have a unit test covering the GDRCopy memtype EP selection path to catch regressions here. |
Member
Author
|
@brminich @nbellalou can you pls take a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Followup on #11358 - Use direct check for ACC device type for memtype_ep selection, instead of indirect RKEY_PTR check