UCT/API: Add strides and counts to uct_ep_put_sgl_zcopy#11401
Open
michal-shalev wants to merge 1 commit intoopenucx:masterfrom
Open
UCT/API: Add strides and counts to uct_ep_put_sgl_zcopy#11401michal-shalev wants to merge 1 commit intoopenucx:masterfrom
michal-shalev wants to merge 1 commit intoopenucx:masterfrom
Conversation
|
This is awesome, I've been waiting for such an extension for a long time. Lately I discovered your devel branches, and I've been using them [almost] successfully. Would it be possible to provide a way to have each one of the rkeys, counts and strides arrays as a single value, with the understanding that in such a case all elements have the same value ? |
iyastreb
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Add two optional
const size_t *parameters,countsandstrides, touct_ep_put_sgl_zcopy(and the matching internal function pointer typedef and dispatch wrapper). When provided, element i representscounts[i]blocks oflengths[i]bytes, each separated bystrides[i]bytes, starting atbuffers[i]/remote_addrs[i]. WhenNULL, each element is transferred once (equivalent to count=1, stride=0), preserving the existing behavior.Why?
The current SGL zero-copy put requires one entry per transferred buffer, so a regular strided layout has to be expanded into long
buffers/lengths/remote_addrsarrays. Allowing per-elementcounts/strideslets the caller describe such patterns compactly.How?
API-only change in
src/uct/api/v2/uct_v2.h, with the matching typedef insrc/uct/base/uct_iface.hand dispatch wrapper insrc/uct/base/uct_iface.cupdated. Implementation will follow in subsequent PRs.