Fix silent crash when dragging invalid .oudep file onto window#2237
Open
KakaruHayate wants to merge 1 commit into
Open
Fix silent crash when dragging invalid .oudep file onto window#2237KakaruHayate wants to merge 1 commit into
KakaruHayate wants to merge 1 commit into
Conversation
The drag-and-drop OUDEP installer path in MainWindow.OnDrop lacked error handling around PackageManager.InstallFromFileAsync. Any validation failure (e.g. missing oudep.yaml, empty entrypoints, invalid package id) threw an unhandled exception that crashed the app because async void methods have no caller to catch. Wrap the call in try/catch and show the error in a message box, matching the pattern already used in OnMenuInstallSinger.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Dragging an invalid or malformed
.oudepfile onto the OpenUtau window causes a silent crash (application exit without error message).Root cause: The OUDEP drag-and-drop handler in
MainWindow.OnDropcallsPackageManager.InstallFromFileAsyncwithout anytry/catch. Since async void methods have no caller to catch exceptions, any validation failure (missingoudep.yaml, emptyentrypoints, missing@class, invalid package id) becomes an unhandled exception that terminates the process.Fix
Wrap the
InstallFromFileAsynccall in atry/catchblock, log the error, and display a message box to the user — matching the same pattern already used inOnMenuInstallSinger(line 586-608 of the same file).Testing
dotnet build OpenUtau.sln— 0 errors.oudep→ immediate crash.oudep→ error message box with details, app continues running