[FX] Redundant sanity test is removed#4080
Merged
AlexanderDokuchaev merged 1 commit intoMay 19, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the TorchFX “sanity” test (and its TinyImageNet dataset helper) that exercised torch.compile(..., backend="openvino"), with the stated intent of eliminating redundant pre-commit coverage.
Changes:
- Deleted
tests/torch/fx/test_sanity.py(TorchFX compile/quantization sanity test). - Removed
TinyImagenetDatasetManagerand related dataset/download dependencies fromtests/torch/fx/helpers.py.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/torch/fx/test_sanity.py | Removes the TorchFX sanity test that ran quantization + torch.compile with the OpenVINO backend. |
| tests/torch/fx/helpers.py | Drops TinyImageNet dataset manager utilities and related imports from TorchFX test helpers. |
Comment on lines
13
to
17
| import torch.fx | ||
| import torch.nn.parallel | ||
| import torch.utils.data | ||
| import torchvision.datasets as datasets | ||
| import torchvision.transforms as transforms | ||
| from fastdownload import FastDownload | ||
| from torch.fx.passes.graph_drawer import FxGraphDrawer | ||
|
|
||
| from nncf.experimental.torch.fx.transformations import apply_quantization_transformations |
| from pathlib import Path | ||
|
|
||
| import torch.fx | ||
| import torch.nn.parallel |
Comment on lines
28
to
30
| def visualize_fx_model(model: torch.fx.GraphModule, output_svg_path: str): | ||
| g = FxGraphDrawer(model, output_svg_path) | ||
| g.get_dot_graph().write_svg(output_svg_path) |
daniil-lyakhov
force-pushed
the
dl/fx/remove_sanity
branch
from
20db81a to
9d65011
Compare
AlexanderDokuchaev
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Redundant sanity test is removed from TorchFX pre-commit.
The https://github.com/openvinotoolkit/nncf/blob/develop/examples/post_training_quantization/torch_fx/resnet18/main.py example covers the torch.compile test in similar fashion
Reason for changes
To remove redundant code
Related tickets
CVS-178803
Tests