Conversation
An attempt to merge config with wrong format will now raise a validation error instead of failing. Fixes openwisp#351
It only prevents the original AttributeError crash and correctly lets the .validate() method handle all validation of the final merged configuration. Fixes openwisp#351
Merge_config now raises ValidationError when templates have incompatible types for the same key (e.g. list vs dict), instead of silently overwriting. Test updated to assert ValidationError. Fixes openwisp#351
Narrowed the incompatible type check in merge_config to only raise ValidationError when a dict or list conflicts with a different type. Scalar overrides (e.g. str to int) are still allowed as before. Fixes openwisp#351
Added ci failure bot caller workflow for netjsonconfig.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe pull request adds three complementary changes: a new GitHub Actions workflow that automatically detects PR context when the Netjsonconfig CI Build workflow fails (using a multi-step fallback strategy), an enhancement to the Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Suggested reviewers
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
2 participants
Checklist
Description of Changes
Added CI failure bot caller workflow