[examples] Remove node expand/fold example and related code #492#517
[examples] Remove node expand/fold example and related code #492#517Sohaibkundi2 wants to merge 2 commits intoopenwisp:masterfrom
Conversation
The node expand/fold example was broken locally with 'Uncaught ReferenceError: module is not defined' and is no longer used in OpenWISP. Removed: - example_templates/netjsongraph-nodeExpand.html - public/assets/data/netjsongraph-foldNodes.json - related import and entry in test/browser.test.utils.js - card link from index.html
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThis pull request removes the "Nodes expand or fold" example and its assets: the example template Sequence Diagram(s)(Skipped — change is removal of example files and does not introduce or alter multi-component control flow requiring a sequence diagram.) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The node expand/fold example was broken locally with 'Uncaught ReferenceError: module is not defined' and is no longer used in OpenWISP.
Removed:
Description of Changes
Removes the broken node expand/fold example as discussed in #492.
The example was failing locally with
Uncaught ReferenceError: module is not defined.This is a focused PR addressing only the nodeExpand removal item from the issue.
Checklist
Reference to Existing Issue
Related to #492
Screenshot
Not applicable - this PR removes a broken example, no visual changes.