Skip to content

[examples] Remove node expand/fold example and related code #492#517

Open
Sohaibkundi2 wants to merge 2 commits intoopenwisp:masterfrom
Sohaibkundi2:issues/492-fix-node-expand-example
Open

[examples] Remove node expand/fold example and related code #492#517
Sohaibkundi2 wants to merge 2 commits intoopenwisp:masterfrom
Sohaibkundi2:issues/492-fix-node-expand-example

Conversation

@Sohaibkundi2
Copy link
Copy Markdown

The node expand/fold example was broken locally with 'Uncaught ReferenceError: module is not defined' and is no longer used in OpenWISP.

Removed:

  • example_templates/netjsongraph-nodeExpand.html
  • public/assets/data/netjsongraph-foldNodes.json
  • related import and entry in test/browser.test.utils.js
  • card link from index.html

Description of Changes

Removes the broken node expand/fold example as discussed in #492.
The example was failing locally with Uncaught ReferenceError: module is not defined.
This is a focused PR addressing only the nodeExpand removal item from the issue.

Checklist

  • I have read the OpenWISP Contributing Guidelines.
  • I have manually tested the changes proposed in this pull request.
  • I have written new test cases for new code and/or updated existing tests for changes to existing code.
  • I have updated the documentation.

Reference to Existing Issue

Related to #492

Screenshot

Not applicable - this PR removes a broken example, no visual changes.



The node expand/fold example was broken locally with
'Uncaught ReferenceError: module is not defined' and
is no longer used in OpenWISP.

Removed:
- example_templates/netjsongraph-nodeExpand.html
- public/assets/data/netjsongraph-foldNodes.json
- related import and entry in test/browser.test.utils.js
- card link from index.html
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 25, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 8e01f50f-2fe1-40b6-8462-39b397963a24

📥 Commits

Reviewing files that changed from the base of the PR and between 4fe9913 and 52273ee.

📒 Files selected for processing (1)
  • index.html
💤 Files with no reviewable changes (1)
  • index.html

📝 Walkthrough

Walkthrough

This pull request removes the "Nodes expand or fold" example and its assets: the example template public/example_templates/netjsongraph-nodeExpand.html, the backing data public/assets/data/netjsongraph-foldNodes.json, the example card link in index.html, and the corresponding mapping entry in test/browser.test.utils.js. No other application logic, exported APIs, or runtime code paths were modified.

Sequence Diagram(s)

(Skipped — change is removal of example files and does not introduce or alter multi-component control flow requiring a sequence diagram.)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • nemesifier
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title uses '[examples]' instead of a required type prefix (fix, change, feature, qa, ci, chores, docs) and does not follow the specified format. Update title to follow '[type] Descriptive title' format, e.g., '[chores] Remove node expand/fold example and related code #492' or '[fix] Remove broken node expand/fold example #492'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description check ✅ Passed The description includes most required sections and checklist items are mostly completed, though the PR notes that new/updated tests were not written for code removal.
Bug Fixes ✅ Passed PR removes broken example files outside npm distribution (dist/, src/). Not applicable to bug fix check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai bot added bug javascript Pull requests that update Javascript code labels Mar 25, 2026
coderabbitai[bot]
coderabbitai bot previously approved these changes Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant