luci-app-nut: update deprecated config names#8434
Draft
danielfdickinson wants to merge 1 commit intoopenwrt:masterfrom
Draft
luci-app-nut: update deprecated config names#8434danielfdickinson wants to merge 1 commit intoopenwrt:masterfrom
danielfdickinson wants to merge 1 commit intoopenwrt:masterfrom
Conversation
10 tasks
This comment has been minimized.
This comment has been minimized.
danielfdickinson
force-pushed
the
pr-nut-update-deprecated-config-names
branch
from
b5b98f9 to
244652e
Compare
Contributor
Author
|
I've realized this does not handle the case of old names for sections, so I am converting this to draft for now. |
danielfdickinson
force-pushed
the
pr-nut-update-deprecated-config-names
branch
from
244652e to
f578f56
Compare
danielfdickinson
changed the title
Some years ago upstream changed the names the primary/secondary UPS system/monitor from master/slave to primary/secondary. It is uncertain how much longer these deprecated names will be accepted by NUT. Therefore update naming to match upstream documentation and configuration. See <https://networkupstools.org/docs/man/upsmon.html>, <https://networkupstools.org/docs/man/upsmon.conf.html>, and <https://networkupstools.org/docs/man/upsd.users.html>. Support for deprected names is retained in this version. Signed-off-by: Daniel F. Dickinson <dfdpublic@wildtechgarden.ca>
danielfdickinson
force-pushed
the
pr-nut-update-deprecated-config-names
branch
from
f578f56 to
b9b2710
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is not from my main or master branch 💩, but a separate branch ✅
Each commit has a valid ✒️
Signed-off-by: <my@email.address>row (viagit commit --signoff)Each commit and PR title has a valid 📝
<package name>: titlefirst line subject for packagesTested on: (architecture, openwrt version, browser) ✅
OpenWrt Version: OpenWrt SNAPSHOT r33436-7d2c244646
OpenWrt Target/Subtarget: bcm27xx/bcm2709
OpenWrt Device: Raspberry Pi 2 Model B Rev 1.1
( Preferred ) Mention: @danielfdickinson @systemcrash
( Optional ) Depends on: e.g. openwrt/packages#pr-number in sister repo
Depends on: nut: ensure correct settings names packages#28875
Description: (describe the changes proposed in this PR)
Description:
Some years ago upstream changed the names the primary/secondary
UPS system/monitor from master/slave to primary/secondary. It is uncertain
how much longer these deprecated names will be accepted by NUT.
Therefore update naming to match upstream documentation and configuration.
See https://networkupstools.org/docs/man/upsmon.html,
https://networkupstools.org/docs/man/upsmon.conf.html, and
https://networkupstools.org/docs/man/upsd.users.html.