luci-app-banip: fix typo Seperator to Separator#8486
Open
R41D1 wants to merge 2 commits intoopenwrt:masterfrom
Open
luci-app-banip: fix typo Seperator to Separator#8486R41D1 wants to merge 2 commits intoopenwrt:masterfrom
R41D1 wants to merge 2 commits intoopenwrt:masterfrom
Conversation
systemcrash
reviewed
Mar 30, 2026
applications/luci-app-banip/htdocs/luci-static/resources/view/banip/feeds.js
Show resolved
Hide resolved
Contributor
|
Please split the .js <-> .po(t) changes to two separate commits, so the .js can be picked to other branches separately. |
R41D1
force-pushed
the
luci-app-banip/fix-separator-typo
branch
from
7712d54 to
374f16e
Compare
Contributor
|
OK - just fix your SoB on both commits. |
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Joshua Klinesmith <joshuaklinesmith@gmail.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Joshua Klinesmith <joshuaklinesmith@gmail.com>
R41D1
force-pushed
the
luci-app-banip/fix-separator-typo
branch
from
374f16e to
08ab617
Compare
Contributor
|
ping @dibdot |
This comment has been minimized.
This comment has been minimized.
Contributor
|
@systemcrash @R41D1 I wouldn’t create a separate PR or commit just to fix a typo; instead, I’d suggest sorting it out in the next regular update. It will take a bit of time, though, as I’m on holiday at the moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The typo was in the source JS, the
.pottemplate, and all 42 translation.pofiles. Updatedmsgidacross all files so translations remain linked.Test plan
🤖 Generated with Claude Code