luci-mod-status: move getConntrackList from ubus to fs.exec#8490
Open
jjm2473 wants to merge 1 commit intoopenwrt:masterfrom
Open
luci-mod-status: move getConntrackList from ubus to fs.exec#8490jjm2473 wants to merge 1 commit intoopenwrt:masterfrom
jjm2473 wants to merge 1 commit intoopenwrt:masterfrom
Conversation
Contributor
Author
This is test on 24.10.5. |
This comment has been minimized.
This comment has been minimized.
bc970ea to
55930d1
Compare
Contributor
Author
|
[v2]:
Link to v1: jjm2473@bc970ea |
55930d1 to
8c72760
Compare
8c72760 to
2a484cc
Compare
Contributor
Author
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
|
That's a good idea, I like it. I just wonder if it would be better to have a dedicated backend route which takes care of the parsing and spits out a JSON for the front end to consume instead of parsing the raw system files in the frontend code directly. |
Contributor
|
LGTM |
Contributor
Author
|
In fact, modern browsers generally outperform routers, so it might be more appropriate to perform the main computation in the browser? |
2a484cc to
f80986d
Compare
Contributor
Author
This comment has been minimized.
This comment has been minimized.
to prevent procd from being kicked off by ubusd due to large amounts of data. See openwrt/openwrt#9747 Fixes openwrt#6360 Signed-off-by: Liangbin Lian <jjm2473@gmail.com>
f80986d to
eb3d445
Compare
Contributor
Author
|
[v3]:
Link to v2: jjm2473@f80986d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



to prevent procd from being kicked off by ubusd
due to large amounts of data.
See openwrt/openwrt#9747
Fixes #6360
Signed-off-by: <my@email.address>row (viagit commit --signoff)<package name>: titlefirst line subject for packagesPKG_VERSIONin the MakefileMove getConntrackList from ubus to web to prevent procd from being kicked off by ubusd due to large amounts of data.
Has been tested with a fake 5MB /proc/net/nf_conntrack, procd not kicked off (Such a large amount of data can actually cause browser lag.).
