luci-theme-material: change -webkit-appearance#8501
luci-theme-material: change -webkit-appearance#8501owlsy wants to merge 1 commit intoopenwrt:masterfrom
Conversation
This comment has been minimized.
This comment has been minimized.
Replace '-webkit-appearance' with 'appearance' (or removed if 'appearance' is already present), as it is non-standard and has since been succeeded by 'appearance', accepted by all current browsers. Signed-off-by: Joshua Criss <owlsy@outlook.com.au>
4d525b4 to
c8432cf
Compare
|
I think that for this change, we should retain the -webkit variant, since it is backwards compatible. The appearance property is available in current browsers, but 'current' is very recent. In the worst case, let's say we accept this change and drop the -webkit variant - how does the layout look if you completely remove this property (i.e. a 'browser that doesn't understand Same comment to the other -webkit PRs |
|
This is true, If For luci-theme-material, I could not see anything visually different.
Noted though that this test is by removing all I'll check the other themes now and comment the results on those pull requests. |
|
It seems ok - although we should still keep the older -webkit variant around for a while before relying exclusively on the appearance variant (for all of your -webkit PRs) |

Notes
-webkit-appearancewithappearance(or removed ifappearanceis already present), as it is a non-standard and has since been succeeded by 'appearance', accepted by all current browsers.