luci-theme-material: refining hide/show buttons#8512
Closed
owlsy wants to merge 2 commits intoopenwrt:masterfrom
Closed
luci-theme-material: refining hide/show buttons#8512owlsy wants to merge 2 commits intoopenwrt:masterfrom
owlsy wants to merge 2 commits intoopenwrt:masterfrom
Conversation
Change mouse icon from text cursor to pointer. Fix buttons not being same min-width. Create larger buttons for smaller screens, same behaviour as luci-theme-bootstrap. Slightly fade "show" button: no variable for disabled opacity like luci-theme-bootstrap, assuming 0.7. Remove fade when hovered. Signed-off-by: Joshua Criss <owlsy@outlook.com.au>
Signed-off-by: Owl <owlsy@outlook.com.au>
Contributor
Author
|
Should I wait for #8508 before rebasing on master and updating this pull request? Edit: Just going to make a new pull request as I can't remove the latest merge commit, I had trouble figuring it out without making more of a mess. |
Failed checksIssues marked with an ❌ are failing checks. Commit a8d6ecd
For more details, see the full job log. Something broken? Consider providing feedback. |
Contributor
Author
|
Messed up the commits and couldn't resolve it. Closing and trying again with #8519. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Notes
PKG_VERSIONin the Makefile.Checklist
Signed-off-by: <my@email.address>row (viagit commit --signoff)<package name>: titlefirst line subject for packagesPKG_VERSIONin the Makefile