luci-app-nut: update to work with drivers in libexec#8615
luci-app-nut: update to work with drivers in libexec#8615danielfdickinson wants to merge 1 commit into
Conversation
openwrt-ai
left a comment
There was a problem hiding this comment.
Reviewed 1 new commit. The change is self-consistent: the new driver_path (/usr/libexec/nut/) with fallback to old_driver_path (/lib/nut/) correctly supports both the pre- and post-openwrt/packages#29390 layouts, and the ACL grants list on both paths. Commit message matches the diff. One minor inline nit below.
Generated by Claude Code
b584657 to
17a51fc
Compare
openwrt-ai
left a comment
There was a problem hiding this comment.
Reviewed 1 new commit; no new issues found. The new head commit (17a51fc) is a force-push of the previously reviewed commit (b584657) with an identical file tree (git diff b584657..17a51fc is empty), so there are no content changes since the last review, and the earlier trailing-semicolon nit has been resolved. The change remains self-consistent: driver_path (/usr/libexec/nut/) with fallback to old_driver_path (/lib/nut/) supports both layouts, and the ACL grants list on both paths. Commit message matches the diff.
Generated by Claude Code
Due to recent CI changes, it is not longer possible to have NUT drivers in /lib/nut, instead they must be in /usr/libexec/nut (as they are executable binaries not libraries). PR openwrt/packages#29592 will make that change for the `nut` package on openwrt/packages. We update luci-app-nut so that it can work with either location. As a side benefit, this means this commit does not need to wait for the above PR to land in packages before adding this commit. While we are here, fix a typo on section title. Signed-off-by: Daniel F. Dickinson <dfdpublic@wildtechgarden.ca>
17a51fc to
8ad9045
Compare
openwrt-ai
left a comment
There was a problem hiding this comment.
Reviewed 1 new commit; no new issues found. The head commit (8ad9045) is a rebase of the previously reviewed commit (17a51fc) onto current master; the three luci-app-nut files (nut_server.js, nut_monitor.js, acl.d/luci-app-nut.json) are byte-identical to the last review, so there are no content changes since then. The change remains self-consistent: driver_path (/usr/libexec/nut/) with fallback to old_driver_path (/lib/nut/) supports both layouts, the ACL grants list on both paths, and the section-title typo fix is correct. Commit message matches the diff.
Generated by Claude Code
Pull request details
Description
Briefly, due to recent CI changes, it is was longer possible to have NUT drivers in /lib/nut as they are not libraries. This motivated moving them to /usr/libexec/nut (as they are executable binaries not libraries), which is the right thing to do even though the CI now allows using /lib/nut for the drivers.
openwrt/packages#29592 makes that change for the
nutpackage.We update luci-app-nut so that it can work with either location. As a side benefit, this means this commit does not need to wait for the above PR to land in packages before adding this commit.
Maintainer
@danielfdickinson, @systemcrash
Tested on
OpenWrt version: OpenWrt SNAPSHOT r34703-aa96b3ad55
LuCI version: LuCI Master (26.149.54726~c4b9631)
Web browser(s): 140.11.0esr (64-bit)
Checklist
Signed-off-by: <my@email.address>row (viagit commit --signoff).<package name>: titlefirst line subject for packages.Works with (but does not require, but is required for): nut: bump version and add migration packages#29592