ddns-scripts: remove service start in postinst #28486
Merged
+1
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Isn't enabling and starting all services the default behavior? Why is that code even there? |
Member
Author
|
You're right. But that's always been the case with this package. I'm not installing the package. I have my own images and therefore don't want to deal with it in detail right now, |
dave14305
reviewed
Feb 3, 2026
feckert
force-pushed
the
pr/20260126-ddns-scripts
branch
2 times, most recently
from
b820d1a to
7065371
Compare
Member
Author
|
@languagegame Can someone please test this again? From my point of view, as described in the commit, the whole postinst and prerm is not necessary. |
3 tasks
For reasons that have not been investigated in detail, the package blocks during 'postinst' with the new 'apk' backend when the package is installed on the target. After much back and forth, it turned out that the '/etc/init.d/ddns start' command is responsible for this. The call is blocking. The command '/etc/init.d/ddns enabled' in the 'postinst' also makes no sense here, as it only checks whether the ddns service is enabled. The return value is not checked at all. And the 'prerm' script is also not needed, as the calls made there are implicitly called during package deinstallation. Therefore, this commit removes the entire and not needed 'postinst' and 'prerm' script call. Signed-off-by: Florian Eckert <fe@dev.tdt.de>
feckert
force-pushed
the
pr/20260126-ddns-scripts
branch
from
7065371 to
c75f347
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📦 Package Details
Maintainer: @me
Description:
Fixes: #28377
For reasons that have not been investigated in detail, the package blocks during 'postinst' with the new 'apk' backend when the package is installed on the target. Deleting this script call '/etc/init.d/ddns start' in postinst solves the problem for apk. This was not observed in the OPKG backend.
Unfortunately, I do not know what side effect this change will have. I never install the package afterwards.
🧪 Run Testing Details
✅ Formalities