ddns-script: update namesilo.com #28525
Open
+17
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Please rebase agains current master. The PKG_RELEASE of ddns-scripts was updated. |
switch xml parser to xmllint because xmlstarlet is not available Signed-off-by: Lin Fan <im.linfan@gmail.com>
Contributor
Author
done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch XML parser to xmllint because xmlstarlet is not available.
📦 Package Details
Maintainer: @feckert
Description: NameSilo's API supports both JSON and XML response formats, with this script defaulting to JSON. If a user selects the XML format, the script originally calls xmlstarlet for parsing. However, since OpenWrt does not include the xmlstarlet package, it always fallback to grep & sed. In this new commit, it has been switched to use xmllint for XML parsing instead.
🧪 Run Testing Details
✅ Formalities